From: Bruce Momjian <bruce@momjian.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Date: Wed, 29 Jul 2020 21:30:50 -0400
Message-ID: <20200730013050.GA30116@momjian.us> (raw)
In-Reply-To: <CAH2-Wzn3kwQm_pe6g2=ki+P7+ZRqH5GvFGn6SWfv_j7UUgcLdQ@mail.gmail.com>
References: <20200626202036.GA5474@alvherre.pgsql>
<20200626202326.GA5823@alvherre.pgsql>
<20200626222423.GC3337@momjian.us>
<CAH2-Wzn3kwQm_pe6g2=ki+P7+ZRqH5GvFGn6SWfv_j7UUgcLdQ@mail.gmail.com>
On Wed, Jul 29, 2020 at 03:34:22PM -0700, Peter Geoghegan wrote:
> Hi Bruce,
>
> On Fri, Jun 26, 2020 at 3:24 PM Bruce Momjian <bruce@momjian.us> wrote:
> > Patch attached and applied to PG 13.
>
> I committed the hash_mem_multiplier GUC to Postgres 13 just now.
>
> There should be a note about this in the Postgres 13 release notes,
> for the usual reasons. More importantly, the "Allow hash aggregation
> to use disk storage for large aggregation result sets" feature should
> reference the new GUC directly. Users should be advised that the GUC
> may be useful in cases where they upgrade and experience a performance
> regression linked to slower hash aggregation. Just including a
> documentation link for the GUC would be very helpful.
I came up with the attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:hash.diff (text/x-diff, 786B) downloaddiff --git a/doc/src/sgml/release-13.sgml b/doc/src/sgml/release-13.sgmlnew file mode 100644index 18e6497..2586645
*** a/doc/src/sgml/release-13.sgml
--- b/doc/src/sgml/release-13.sgml
*************** Author: Jeff Davis <jdavis@postgresql.or
*** 649,655 ****
<para>
Previously, hash aggregation was avoided if it was expected to use
! more than <xref linkend="guc-work-mem"/> memory.
</para>
</listitem>
--- 649,657 ----
<para>
Previously, hash aggregation was avoided if it was expected to use
! more than <xref linkend="guc-work-mem"/> memory. To use more
! memory for hash query operations, increase <xref
! linkend="guc-hash-mem-multiplier"/>.
</para>
</listitem>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, pg@bowt.ie, alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com
Subject: Re: PG 13 release notes, first draft
In-Reply-To: <20200730013050.GA30116@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox