From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Thu, 13 Aug 2020 16:16:28 -0400
Message-ID: <20200813201628.GA29590@tamriel.snowman.net> (raw)
In-Reply-To: <CA+TgmoYNGNucnPnaEKDbhQQJL8wETmZcnBzpjiKNzaTzbqV9BA@mail.gmail.com>
References: <20200812223409.6di3y2qsnvynao7a@alap3.anarazel.de>
<CAGf+fX71Oa2vzg0xdj+vgrjmdVrm=kRLc7H3SEGtCHkGhoWDCg@mail.gmail.com>
<328084.1597276021@sss.pgh.pa.us>
<20200813035308.GA1137170@rfd.leadboat.com>
<397020.1597291716@sss.pgh.pa.us>
<CABUevEwg3LmBk-+ZiAYZW71dsB=boS-8sdYBux7M6qZp46avtA@mail.gmail.com>
<20200813163043.GZ29590@tamriel.snowman.net>
<CA+TgmoYNGNucnPnaEKDbhQQJL8wETmZcnBzpjiKNzaTzbqV9BA@mail.gmail.com>
Greetings,
* Robert Haas (robertmhaas@gmail.com) wrote:
> On Thu, Aug 13, 2020 at 12:30 PM Stephen Frost <sfrost@snowman.net> wrote:
> > So, in our world, wouldn't this translate to 'make cfbot complain'?
>
> This seems like it would be useful, but we'd have to figure out what
> to do about typedefs.list. If the patch is indented with the current
> one (which is auto-generated by the entire build farm, remember) it's
> likely to mess up a patch that's otherwise properly formatted. We'd
> either need to insist that people include updates to typedefs.list in
> the patch, or else have the cfbot take a stab at doing those updates
> itself.
For my 2c, anyway, I like the idea of having folks update the typedefs
themselves when they've got a patch that needs a new typedef to be
indented correctly. Having cfbot try to do that seems unlikely to work
well.
I also didn't mean to imply that we'd push back and ask for a rebase due
to indentation changes, but at the same time, I question if it's really
that realistic a concern- either whomever posted the patch ran pgindent
on it, or they didn't, and I doubt cfbot's check of that would change
without there being a conflict between the patch and something that got
committed anyway.
I also disagree that it's that much of a burden to ask people who are
already hacking on PG to install pgindent.
All that said, seems that others feel differently and while I still
think it's a pretty reasonable idea to have cfbot check, if no one
agrees with me, that's fine too. Having the pre-commit hook would help
with the downstream issue of pgindent pain from unrelated incorrect
indentation, so at least dealing with the patch author not properly
indenting to start with would be just on the bits the patch is already
modifying, which is a lot better.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, robertmhaas@gmail.com, magnus@hagander.net, tgl@sss.pgh.pa.us, noah@leadboat.com, sbjesse@gmail.com, andres@anarazel.de
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <20200813201628.GA29590@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox