From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE
Date: Mon, 17 Aug 2020 16:00:17 +0900
Message-ID: <20200817070017.GE7787@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1Lf-typx7ngR8igFqDRoayLQmUmQh0yMd=RAUrdPSg96Q@mail.gmail.com>
References: <07b33e2c-46a6-86a1-5f9e-a7da73fddb95@iki.fi>
<CAA4eK1Lf-typx7ngR8igFqDRoayLQmUmQh0yMd=RAUrdPSg96Q@mail.gmail.com>
On Sat, Aug 15, 2020 at 11:05:43AM +0530, Amit Kapila wrote:
> On Fri, Aug 14, 2020 at 2:17 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> It's always been like that, but I am not going backport, for fear of
>> breaking existing applications. If a program reads the WAL, and would
>> actually need to do something with commit records dropping relations,
>> that seems like such a common scenario that the author should've thought
>> about it and handled it even without the flag reminding about it. Fixing
>> it in master ought to be enough.
>
> +1 for doing it in master only. Even if someone comes up with such a
> scenario for back-branches, we can revisit our decision to backport
> this but like you, I also don't see any pressing need to do it now.
+1.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, amit.kapila16@gmail.com, hlinnaka@iki.fi
Subject: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE
In-Reply-To: <20200817070017.GE7787@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox