From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Steele <david@pgmasters.net>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: Wed, 16 Sep 2020 11:37:03 +0200
Message-ID: <20200916093703.rkyl66ggdhmw5pc6@localhost> (raw)
In-Reply-To: <CAFj8pRA784QJU2Yr-f-frgRdXNuA4b50ug8as=NyzPSiV-K5bA@mail.gmail.com>
References: <20200516122802.g4qbfxkr2zr7nlv2@localhost>
<20200719191016.GW23581@telsasoft.com>
<20200720160216.lav6vmyv6wbg7bfl@localhost>
<20200728134308.qsstgwyyx3ngsfcw@localhost>
<1808585.1596224122@sss.pgh.pa.us>
<20200801143334.d7d3tsb7gaezx6vq@localhost>
<CAFj8pRBZ_82spPExOa-m+Fed4=yvufvx0kKcga7GQbszJvG-BA@mail.gmail.com>
<20200805140422.fzwnvq7qr5vsgx3b@localhost>
<20200909210435.GU18552@telsasoft.com>
<CAFj8pRA784QJU2Yr-f-frgRdXNuA4b50ug8as=NyzPSiV-K5bA@mail.gmail.com>
> st 9. 9. 2020 v 23:04 Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> This seems to already hit a merge conflict (8febfd185).
> Would you re-rebase ?
Thanks. Sure, will post a rebased version soon.
> On Tue, Sep 15, 2020 at 08:42:40PM +0200, Pavel Stehule wrote:
>
> Maybe I found a another issue.
>
> create table foo(a jsonb);
>
> postgres=# select * from foo;
> ┌───────────────────────────────────────────────────────────────────┐
> │ a │
> ╞═══════════════════════════════════════════════════════════════════╡
> │ [0, null, null, null, null, null, null, null, null, null, "ahoj"] │
> └───────────────────────────────────────────────────────────────────┘
> (1 row)
>
> It is working like I expect
>
> but
>
> postgres=# truncate foo;
> TRUNCATE TABLE
> postgres=# insert into foo values('[]');
> INSERT 0 1
> postgres=# update foo set a[10] = 'ahoj';
> UPDATE 1
> postgres=# select * from foo;
> ┌──────────┐
> │ a │
> ╞══════════╡
> │ ["ahoj"] │
> └──────────┘
> (1 row)
Thanks for looking at the last patch, I appreciate! The situation you've
mention is an interesting edge case. If I understand correctly, the
first example is the result of some operations leading to filling gaps
between 0 and "ahoj". In the second case there is no such gap that's why
nothing was "filled in", although one could expect presence of a "start
position" and fill with nulls everything from it to the new element, is
that what you mean?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: 9erthalion6@gmail.com, pavel.stehule@gmail.com, pryzby@telsasoft.com, tgl@sss.pgh.pa.us, david@pgmasters.net, n.gluhov@postgrespro.ru, alvherre@2ndquadrant.com, david@fetter.org, thomas.munro@gmail.com, thomas.munro@enterprisedb.com, oleksandr.shulgin@zalando.de, robertmhaas@gmail.com, andres@anarazel.de, michael.paquier@gmail.com, obartunov@gmail.com, peter.eisentraut@2ndquadrant.com
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
In-Reply-To: <20200916093703.rkyl66ggdhmw5pc6@localhost>
References: <20200516122802.g4qbfxkr2zr7nlv2@localhost> <20200719191016.GW23581@telsasoft.com> <20200720160216.lav6vmyv6wbg7bfl@localhost> <20200728134308.qsstgwyyx3ngsfcw@localhost> <1808585.1596224122@sss.pgh.pa.us> <20200801143334.d7d3tsb7gaezx6vq@localhost> <CAFj8pRBZ_82spPExOa-m+Fed4=yvufvx0kKcga7GQbszJvG-BA@mail.gmail.com> <20200805140422.fzwnvq7qr5vsgx3b@localhost> <20200909210435.GU18552@telsasoft.com> <CAFj8pRA784QJU2Yr-f-frgRdXNuA4b50ug8as=NyzPSiV-K5bA@mail.gmail.com> <20200916093703.rkyl66ggdhmw5pc6@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox