From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
Date: Mon, 21 Sep 2020 16:37:34 -0300
Message-ID: <20200921193734.GA3486@alvherre.pgsql> (raw)
In-Reply-To: <1023612.1600716072@sss.pgh.pa.us>
On 2020-Sep-21, Tom Lane wrote:
> > ... isn't this more likely to create a typedef entry than merely a
> > function name?
>
> Well, yeah, it *is* a typedef. My proposal is to rename the C function
> to avoid the conflict, rather than renaming the typedef. Given the
> small number of direct calls (none), that's a lot less work. Also,
> I think pgtypes_numeric.h is exposed to ecpg client code, so changing
> that typedef's name could be quite problematic.
Ah, of course.
The idea of adding the names to pgindent's %blacklist results in severe
uglification, particularly in the regex code, so +1 for your workaround.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, daniel@yesql.se, peter.eisentraut@2ndquadrant.com
Subject: Re: pgindent vs dtrace on macos
In-Reply-To: <20200921193734.GA3486@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox