From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: k.jamison@fujitsu.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: please update ps display for recovery checkpoint
Date: Fri, 2 Oct 2020 04:13:54 -0500
Message-ID: <20201002091354.GH8476@telsasoft.com> (raw)
In-Reply-To: <20201002072814.GE1464@paquier.xyz>
References: <20200818225238.GP17022@telsasoft.com>
<OSBPR01MB2341D2D3141FB3E4C97A0B4DEF5D0@OSBPR01MB2341.jpnprd01.prod.outlook.com>
<20200820080905.GA10353@paquier.xyz>
<20200831065244.GB6555@paquier.xyz>
<20200910020050.GB18552@telsasoft.com>
<20200910043710.GD2743@paquier.xyz>
<20200919160031.GC30557@telsasoft.com>
<20201002072814.GE1464@paquier.xyz>
On Fri, Oct 02, 2020 at 04:28:14PM +0900, Michael Paquier wrote:
> > Related: I have always thought that this message meant "recovery will complete
> > Real Soon", but I now understand it to mean "beginning the recovery checkpoint,
> > which is flagged CHECKPOINT_IMMEDIATE" (and may take a long time).
>
> Yep. And at the end of crash recovery seconds feel like minutes.
>
> I agree that "checkpointer checkpoint" is not the best fit. Using
> parenthesis would also be inconsistent with the other usages of this
> API in the backend code.
I think maybe I got the idea for parenthesis from these:
src/backend/tcop/postgres.c: set_ps_display("idle in transaction (aborted)");
src/backend/postmaster/postmaster.c- if (port->remote_port[0] != '\0')
src/backend/postmaster/postmaster.c- appendStringInfo(&ps_data, "(%s)", port->remote_port);
> What about adding "running" then? This
> would give "checkpointer running end-of-recovery checkpoint".
What about one of these?
"checkpointer: running end-of-recovery checkpoint"
"checkpointer running: end-of-recovery checkpoint"
Thanks for looking.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, k.jamison@fujitsu.com
Subject: Re: please update ps display for recovery checkpoint
In-Reply-To: <20201002091354.GH8476@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox