pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Drouvot, Bertrand <bdrouvot@amazon.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add Information during standby recovery conflicts
Date: Sun, 4 Oct 2020 11:10:34 -0300
Message-ID: <20201004141034.GA6361@alvherre.pgsql> (raw)
In-Reply-To: <29da248a-e21c-a3eb-a051-f1ec79b13d31@amazon.com>

> +extern const char *get_procsignal_reason_desc(ProcSignalReason reason)
> +	{
> +		const char *reasonDesc = "unknown reason";
> +
> +		switch (reason)
> +		{
> +			case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN:
> +				reasonDesc = "buffer pin";
> +				break;

It doesn't work to construct sentences from pieces, for translatability
reasons.  Maybe you can return the whole errmsg sentence from this
routine instead.

view thread (82+ messages)  latest in thread

Message-ID: <20201004141034.GA6361@alvherre.pgsql>
Permalink:  ../20201004141034.GA6361@alvherre.pgsql/
Also on:    postgresql.org/message-id/20201004141034.GA6361@alvherre.pgsql

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, bdrouvot@amazon.com, masahiko.sawada@2ndquadrant.com
  Subject: Re: Add Information during standby recovery conflicts
  In-Reply-To: <20201004141034.GA6361@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox