pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@postgresql.org
Cc: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: jit and explain nontext
Date: Wed, 14 Oct 2020 14:39:00 -0500
Message-ID: <20201014193859.GS9241@telsasoft.com> (raw)

        /* don't print information if no JITing happened */
        if (!ji || ji->created_functions == 0)
                return;

This applies even when (es->format != EXPLAIN_FORMAT_TEXT), which I think is
wrong.  Jit use can be determined by cost, so I think jit details should be
shown in non-text format whenever ji!=NULL, even if it's zeros.  Arguably, bits
could be omitted if jit_expressions=off or jit_tuple_deforming=off, but I don't
see the point.

-- 
Justin





view thread (16+ messages)  latest in thread

Message-ID: <20201014193859.GS9241@telsasoft.com>
Permalink:  ../20201014193859.GS9241@telsasoft.com/
Also on:    postgresql.org/message-id/20201014193859.GS9241@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, andres@anarazel.de, dgrowleyml@gmail.com
  Subject: Re: jit and explain nontext
  In-Reply-To: <20201014193859.GS9241@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox