pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: please update ps display for recovery checkpoint
Date: Sun, 13 Dec 2020 21:22:24 -0600
Message-ID: <20201214032224.GA30237@telsasoft.com> (raw)
In-Reply-To: <X9bVjWjCb5yxgDwN@paquier.xyz>
References: <549f04f1-6362-b599-c5e6-87330e36f03d@oss.nttdata.com>
	<X9Brc31Jj5cemRUw@paquier.xyz>
	<B8C46DD1-557F-4D20-97DD-DBC16772457F@amazon.com>
	<X9Ltbgcqy18Xvizq@paquier.xyz>
	<20201211040210.GZ24052@telsasoft.com>
	<X9Ly3zWGtaIfaRYT@paquier.xyz>
	<59A309AA-87C4-457E-A9D4-922BC5A418BA@amazon.com>
	<X9QH9ztwiVt1Lk/N@paquier.xyz>
	<B08B7934-A7DA-4A4E-BBFC-3505667F2B7E@amazon.com>
	<X9bVjWjCb5yxgDwN@paquier.xyz>

On Mon, Dec 14, 2020 at 12:01:33PM +0900, Michael Paquier wrote:
> On Sat, Dec 12, 2020 at 12:41:25AM +0000, Bossart, Nathan wrote:
> > On 12/11/20, 4:00 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> >> My counter-proposal is like the attached, with the set/reset part not
> >> reversed this time, and the code indented :p
> > 
> > Haha.  LGTM.
> 
> Thanks.  I have applied this one, then.

Thank you.

I'm not sure, but we could consider backpatching something to clear the
"recovering NNN" that's currently displayed during checkpoint, even though
recovery of NNN has already completed.  Possibly just calling
set_ps_display(""); after "Real work is done".

-- 
Justin





view thread (30+ messages)  latest in thread

Message-ID: <20201214032224.GA30237@telsasoft.com>
Permalink:  ../20201214032224.GA30237@telsasoft.com/
Also on:    postgresql.org/message-id/20201214032224.GA30237@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz, bossartn@amazon.com, masao.fujii@oss.nttdata.com, k.jamison@fujitsu.com, thomas.munro@gmail.com
  Subject: Re: please update ps display for recovery checkpoint
  In-Reply-To: <20201214032224.GA30237@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox