From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Subject: Re: Proposed patch for key managment
Date: Thu, 17 Dec 2020 11:39:55 -0500
Message-ID: <20201217163954.GY16415@tamriel.snowman.net> (raw)
In-Reply-To: <X9qXuLekePLRYrB2@paquier.xyz>
References: <20201202213814.GG20285@momjian.us>
<20201214230615.GA14596@momjian.us>
<X9gL7bD9idE2hoFt@paquier.xyz>
<20201215031902.GB14596@momjian.us>
<X9hHoQcZ11pBtgnz@paquier.xyz>
<20201215210212.GG14596@momjian.us>
<X9lhi1ht04I+v/rV@paquier.xyz>
<20201216220412.GB4527@momjian.us>
<X9qXuLekePLRYrB2@paquier.xyz>
Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Wed, Dec 16, 2020 at 05:04:12PM -0500, Bruce Momjian wrote:
> >> fallback implementation. Finally, pgcrypto is not touched, but we
> >
> > I have a fallback implemention --- it fails? ;-) Did you want me to
> > include an AES implementation?
>
> No idea about this one yet. There are no direct users of AES except
> pgcrypto in core. One thing that would be good IMO is to properly
> split the patch of this thread into individual parts that could be
> reviewed separately using for example "git format-patch" to generate
> patch series. What's presented is a mixed bag, so that's harder to
> look at it and consider how this stuff should work, and if there are
> pieces that should be designed better or not.
I don't think there's any need for us to implement a fallback
implementation of AES. I'm not entirely sure we need it for hashes
but since we've already got it...
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, michael@paquier.xyz, bruce@momjian.us, masahiko.sawada@2ndquadrant.com
Subject: Re: Proposed patch for key managment
In-Reply-To: <20201217163954.GY16415@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox