From: Justin Pryzby <pryzby@telsasoft.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pglz compression performance, take two
Date: Tue, 29 Dec 2020 22:39:30 -0600
Message-ID: <20201230043930.GG25152@telsasoft.com> (raw)
In-Reply-To: <25991595-1848-4178-AA57-872B10309DA2@yandex-team.ru>
References: <FEF3DC5E-4BC4-44E1-8DEB-DADC67046FE3@yandex-team.ru>
<D75ABE30-2AAA-47DB-A89F-665E03BAAD2A@yandex-team.ru>
<25991595-1848-4178-AA57-872B10309DA2@yandex-team.ru>
On Sat, Dec 26, 2020 at 12:06:59PM +0500, Andrey Borodin wrote:
> > 12 дек. 2020 г., в 22:47, Andrey Borodin <x4mmm@yandex-team.ru> написал(а):
> I've cleaned up comments, checked that memory alignment stuff actually make sense for 32-bit ARM (according to Godbolt) and did some more code cleanup. PFA v2 patch.
>
> I'm still in doubt should I register this patch on CF or not. I'm willing to work on this, but it's not clear will it hit PGv14. And I hope for PGv15 we will have lz4 or something better for WAL compression.
Thanks for registering it.
There's some typos in the current patch;
farer (further: but it's not your typo)
positiion
reduce a => reduce the
monotonicity what => monotonicity, which
lesser good => less good
allign: align
This comment I couldn't understand:
+ * As initial compare for short matches compares 4 bytes then for the end
+ * of stream length of match should be cut
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, x4mmm@yandex-team.ru
Subject: Re: pglz compression performance, take two
In-Reply-To: <20201230043930.GG25152@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox