pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Banck <michael.banck@credativ.de>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Online checksums patch - once again
Date: Tue, 5 Jan 2021 14:40:04 -0600
Message-ID: <20210105204004.GL1849@telsasoft.com> (raw)
In-Reply-To: <5ff4cc2c.1c69fb81.6e306.046b@mx.google.com>
References: <20200919021811.GA30557@telsasoft.com>
	<91DC9350-7269-4B0F-AF87-AE62243D53AD@yesql.se>
	<b832a496-f0aa-c7e4-cca4-6bd0af4d4a90@iki.fi>
	<329E487A-E0E9-481C-985E-52888302487C@yesql.se>
	<d89d50a9-06b8-dff6-d80d-9bd3a841216c@iki.fi>
	<65E8272D-90AA-4194-A8F0-A8EAA0880B03@yesql.se>
	<8e1cda9b-1cb9-a634-d383-f757bf67b820@iki.fi>
	<4D2BC45F-CAE9-451C-AD08-FDB199008E6D@yesql.se>
	<1B6F5100-6518-4864-8F26-213A45ED6E54@yesql.se>
	<5ff4cc2c.1c69fb81.6e306.046b@mx.google.com>

On Tue, Jan 05, 2021 at 09:29:31PM +0100, Michael Banck wrote:
> > @@ -4938,13 +4949,299 @@ GetMockAuthenticationNonce(void)
> >  /*
> > - * Are checksums enabled for data pages?
> > + * DataChecksumsNeedWrite
> > + *		Returns whether data checksums must be written or not
> > + *
> > + * Are checksums enabled, or in the process of being enabled, for data pages?
> 
> The second "," looks odd and could be ommitted?.

Maybe write:

> > + * Are checksums on data pages enabled, or in the process of being enabled ?

view thread (87+ messages)  latest in thread

Message-ID: <20210105204004.GL1849@telsasoft.com>
Permalink:  ../20210105204004.GL1849@telsasoft.com/
Also on:    postgresql.org/message-id/20210105204004.GL1849@telsasoft.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael.banck@credativ.de, daniel@yesql.se, hlinnaka@iki.fi, robertmhaas@gmail.com, magnus@hagander.net, michael@paquier.xyz, andres@anarazel.de, tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Online checksums patch - once again
  In-Reply-To: <20210105204004.GL1849@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox