pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Konstantin Knizhnik <knizhnik@garret.ru>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Cc: Denis Smirnov <sd@arenadata.io>
Cc: Daniil Zakhlystov <usernamedt@yandex-team.ru>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq compression
Date: Tue, 12 Jan 2021 09:38:22 -0600
Message-ID: <20210112153822.GA1849@telsasoft.com> (raw)
In-Reply-To: <c48a2651-b8da-65ba-0cb9-64f497e29229@garret.ru>
References: <CA+TgmoZMTLydjP3iWBir20OrSXTugxS2CXC1WP1nWM5=Zqz0Nw@mail.gmail.com>
	<A1D0D9A4-1FC4-4311-83C7-EEA90749EE07@yandex-team.ru>
	<CA+TgmoZrM9T_W9YR-vLYZXj-vC_+F-DER65A87+pDXRwUFjJXg@mail.gmail.com>
	<D5354E7A-3B9F-4D32-B3AB-F65058D36500@yandex-team.ru>
	<CCAB1F57-A71D-4DEC-9A9C-F325B44BAC29@arenadata.io>
	<93027ee4-fefa-a8ca-2cc7-245c912bf824@postgrespro.ru>
	<20210109203119.GL1849@telsasoft.com>
	<f02d6f64-fe5e-f507-4870-f433cf253441@postgrespro.ru>
	<e71f05b5-777e-8ef3-08f5-87190e179874@enterprisedb.com>
	<c48a2651-b8da-65ba-0cb9-64f497e29229@garret.ru>

On Tue, Jan 12, 2021 at 08:44:43AM +0300, Konstantin Knizhnik wrote:
> On 11.01.2021 20:38, Tomas Vondra wrote:
> > 1) Fixes the MSVC makefile. The list of files is sorted alphabetically,
> > so I've added the file at the end.
> Thank you

This is still failing the windows build.

I think you need something like this, which I have in my zstd/pg_dump patch.


inline patch 1: src/tools/msvc/Solution.pm (+1/-0 lines) download inline-1.patch--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -307,6 +307,7 @@ sub GenerateFiles
                HAVE_LIBXML2                                => undef,
                HAVE_LIBXSLT                                => undef,
                HAVE_LIBZ                   => $self->{options}->{zlib} ? 1 : undef,
+               HAVE_LIBZSTD                => $self->{options}->{zstd} ? 1 : undef,



I think we should come up with an minimal, prelimininary 0001 patch which is
common between the 3 compression patches (or at least the two using zstd).  The
./configure changes and a compressionlibs struct would also be included.  I'm
planning to do something like this with the next revision of my patchset.

-- 
Justin





view thread (289+ messages)  latest in thread

Message-ID: <20210112153822.GA1849@telsasoft.com>
Permalink:  ../20210112153822.GA1849@telsasoft.com/
Also on:    postgresql.org/message-id/20210112153822.GA1849@telsasoft.com

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, knizhnik@garret.ru, tomas.vondra@enterprisedb.com, k.knizhnik@postgrespro.ru, sd@arenadata.io, usernamedt@yandex-team.ru, x4mmm@yandex-team.ru, dilipbalaut@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: libpq compression
  In-Reply-To: <20210112153822.GA1849@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox