pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Subject: Re: Key management with tests
Date: Fri, 15 Jan 2021 16:47:19 -0500
Message-ID: <20210115214719.GE8740@momjian.us> (raw)
In-Reply-To: <CA+Tgmoaon7NE0FxH7HXiF4cFJvkn0qMui_oxyvkO6Ri9+D7u4A@mail.gmail.com>
References: <20210101045047.GB30966@momjian.us>
	<20210101060750.GA7432@momjian.us>
	<20210109181736.GB19555@momjian.us>
	<20210110010816.GC19555@momjian.us>
	<20210110024529.GD19555@momjian.us>
	<CA+hUKGL21_sf1gj2oxqGMEMJHxybZ_9v+9auz0_VDaDsUJZ+NQ@mail.gmail.com>
	<20210110145116.GE19555@momjian.us>
	<20210112170409.GN4320@momjian.us>
	<20210115204926.GD8740@momjian.us>
	<CA+Tgmoaon7NE0FxH7HXiF4cFJvkn0qMui_oxyvkO6Ri9+D7u4A@mail.gmail.com>

On Fri, Jan 15, 2021 at 04:23:22PM -0500, Robert Haas wrote:
> On Fri, Jan 15, 2021 at 3:49 PM Bruce Momjian <bruce@momjian.us> wrote:
> > I am planning to apply this next week.
> 
> I don't think that's appropriate. Several prominent community members
> have told you that the patch, as committed the first time, needed a
> lot more work. There hasn't been enough time between then and now for
> you, or anyone, to do that amount of work. This patch needs detailed
> and substantial review from senior community members, and multiple
> rounds of feedback and improvement, before it should be considered for
> commit.
> 
> I am not even sure there is a consensus on the design, without which
> any commit is always premature.

If people want changes, I need to hear about it here.  I have address
everything people have mentioned in these threads so far.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee






view thread (114+ messages)  latest in thread

Message-ID: <20210115214719.GE8740@momjian.us>
Permalink:  ../20210115214719.GE8740@momjian.us/
Also on:    postgresql.org/message-id/20210115214719.GE8740@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, robertmhaas@gmail.com, thomas.munro@gmail.com, sfrost@snowman.net, masahiko.sawada@2ndquadrant.com
  Subject: Re: Key management with tests
  In-Reply-To: <20210115214719.GE8740@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox