From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Matthieu Garrigues <matthieu.garrigues@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Dave Cramer <davecramer@postgres.rocks>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Claudio Freire <klaussfreire@gmail.com>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: Fri, 19 Feb 2021 17:46:51 -0300
Message-ID: <20210219204651.GA32724@alvherre.pgsql> (raw)
In-Reply-To: <CALNJ-vQMeFYb==v5ySLy_oNqoHJ_pt2+9cKyj1pzy_NJKU7H9w@mail.gmail.com>
Hi,
On 2021-Feb-19, Zhihong Yu wrote:
> Hi,
> +static int pqBatchProcessQueue(PGconn *conn);
>
> I was suggesting changing:
>
> +int
> +PQexitBatchMode(PGconn *conn)
>
> to:
>
> +static int
> +PQexitBatchMode(PGconn *conn)
I understand that, but what I'm saying is that it doesn't work.
pqBatchProcessQueue can be static because it's only used internally in
libpq, but PQexitBatchMode is supposed to be called by the client
application.
--
Álvaro Herrera Valdivia, Chile
"No necesitamos banderas
No reconocemos fronteras" (Jorge González)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, zyu@yugabyte.com, david.g.johnston@gmail.com, daniel@manitou-mail.org, matthieu.garrigues@gmail.com, michael@paquier.xyz, davecramer@postgres.rocks, craig@2ndquadrant.com, vaishnaviprabakaran@gmail.com, andres@anarazel.de, michael.paquier@gmail.com, klaussfreire@gmail.com, heikki.linnakangas@iki.fi
Subject: Re: PATCH: Batch/pipelining support for libpq
In-Reply-To: <20210219204651.GA32724@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox