pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: David Steele <david@pgmasters.net>
Cc: Ildus Kurbangaliev <i.kurbangaliev@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods
Date: Fri, 12 Mar 2021 04:36:50 -0600
Message-ID: <20210312103650.GR8796@telsasoft.com> (raw)
In-Reply-To: <CAFiTN-snEyq1QG5TgkoQeVyCvJHqw5m5Nq416ZpPcs372Z-4Gw@mail.gmail.com>
References: <CAFiTN-uxeRxCROr50e62eqog0nAi+FFi1m25f_D5D0-QsdDp1Q@mail.gmail.com>
	<20210306195751.GW29832@telsasoft.com>
	<CAFiTN-tjZrn1OrykBUvzf4_GU7HUPBjSbdwM8_SVnD-9gMWHdA@mail.gmail.com>
	<CA+TgmoZ9sWS_8OHqvTAhmRX-2PoK4UMFiSU4QgKbhAosT1RTzQ@mail.gmail.com>
	<CAFiTN-sBF8ZK3XP105AybsH5s5KtyWoRNbYzgPXQOKACdn1a_Q@mail.gmail.com>
	<CA+TgmoY5gTwurzHM3Ofv-jVTXGkmJqYib_+B9ev_7JKop9NmjQ@mail.gmail.com>
	<CAFiTN-sK1TbCpbFRDF+-TaG4G_hw4S4vUKujGepwg_A7On9UNg@mail.gmail.com>
	<20210311032057.GZ2021@telsasoft.com>
	<CAFiTN-tzAzGroskaqm-cCOctHxBpDccXkKsDPBX4RTv9ETpBNw@mail.gmail.com>
	<CAFiTN-snEyq1QG5TgkoQeVyCvJHqw5m5Nq416ZpPcs372Z-4Gw@mail.gmail.com>

I think these names need to be more specific.

+typedef enum CompressionId
+{
+        PGLZ_COMPRESSION_ID = 0,
+        LZ4_COMPRESSION_ID = 1
+

CompressionId, PGLZ_COMPRESSION_ID, LZ4_COMPRESSION_ID are also being used by
Andrey's WAL compression patch.  I suggested he use a prefix, but your patch is
also of limited scope (TOAST).

-- 
Justin





view thread (430+ messages)  latest in thread

Message-ID: <20210312103650.GR8796@telsasoft.com>
Permalink:  ../20210312103650.GR8796@telsasoft.com/
Also on:    postgresql.org/message-id/20210312103650.GR8796@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, dilipbalaut@gmail.com, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, a.korotkov@postgrespro.ru, david@pgmasters.net, i.kurbangaliev@gmail.com, 9erthalion6@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: [HACKERS] Custom compression methods
  In-Reply-To: <20210312103650.GR8796@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox