pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Paul Guo <guopa@vmware.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Brown <michael.brown@discourse.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: fdatasync performance problem with large number of DB files
Date: Thu, 18 Mar 2021 10:03:52 -0400
Message-ID: <20210318140352.GC8529@momjian.us> (raw)
In-Reply-To: <20210318135411.GB8529@momjian.us>
References: <CA+hUKGLABi5asn5yFXBrAC0d3dGBN8QHvLq=27sa7thCQV4Z1w@mail.gmail.com>
	<CA+hUKGK0hZ1jBCF6r+J9=CVwpAUTU7EB3_SUp5Owp0zym4eksg@mail.gmail.com>
	<823DAB20-5A5E-4F7B-BF8C-D61FA574DEEA@vmware.com>
	<CA+hUKGJi11x6cHJQNeDnLRvk1GMX18DJQaKFqwCOjgeFnbiVKA@mail.gmail.com>
	<76de0e61-a553-6003-aeec-cb35ada791cf@oss.nttdata.com>
	<CA+hUKGJTERHhpAja3KvwF=0qPTgnFB=QPrR=sHmqWKJ2o2mr2Q@mail.gmail.com>
	<52453bfc-40fb-7771-05ee-cbd04b6b9b6e@oss.nttdata.com>
	<4CB921E5-772B-42F9-B14D-D310E709E8F2@vmware.com>
	<CA+hUKGLkoO6i2qoP6u9uKPx8SL4MGzMnT+xQJ+p_x3FggH1Z8A@mail.gmail.com>
	<20210318135411.GB8529@momjian.us>

On Thu, Mar 18, 2021 at 09:54:11AM -0400, Bruce Momjian wrote:
> On Thu, Mar 18, 2021 at 11:19:13PM +1300, Thomas Munro wrote:
> > On Thu, Mar 18, 2021 at 8:52 PM Paul Guo <guopa@vmware.com> wrote:
> > > About the syncfs patch, my first impression on the guc name sync_after_crash
> > > is that it is a boolean type. Not sure about other people's feeling. Do you guys think
> > > It is better to rename it to a clearer name like sync_method_after_crash or others?
> > 
> > Works for me.  Here is a new version like that, also including the
> > documentation change discussed with Fujii-san, and a couple of
> > cosmetic changes.
> 
> Are we sure we want to use the word "crash" here?  I don't remember
> seeing it used anywhere else in our user interface.  I guess it is
> "crash recovery".

Maybe call it "recovery_sync_method"?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.






view thread (49+ messages)  latest in thread

Message-ID: <20210318140352.GC8529@momjian.us>
Permalink:  ../20210318140352.GC8529@momjian.us/
Also on:    postgresql.org/message-id/20210318140352.GC8529@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, thomas.munro@gmail.com, guopa@vmware.com, masao.fujii@oss.nttdata.com, tgl@sss.pgh.pa.us, michael.brown@discourse.org
  Subject: Re: fdatasync performance problem with large number of DB files
  In-Reply-To: <20210318140352.GC8529@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox