From: 'alvherre@alvh.no-ip.org' <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: iwata.aya@fujitsu.com <iwata.aya@fujitsu.com>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Date: Thu, 1 Apr 2021 16:05:36 -0300
Message-ID: <20210401190536.GA29620@alvherre.pgsql> (raw)
In-Reply-To: <3455705.1617299197@sss.pgh.pa.us>
On 2021-Apr-01, Tom Lane wrote:
> "'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org> writes:
> > On 2021-Apr-01, Tom Lane wrote:
> >> BTW, what in the world is this supposed to accomplish?
> >> - (long long) rows_to_send);
> >> + (1L << 62) + (long long) rows_to_send);
>
> > It makes the text representation wider, which means some buffer fills up
> > faster and the program switches from sending to receiving.
>
> Hm. If the actual field value isn't relevant, why bother including
> rows_to_send in it? A constant string would be simpler and much
> less confusing as to its purpose.
Hah, yeah, we could as well do that I guess :-)
--
Álvaro Herrera Valdivia, Chile
"I think my standards have lowered enough that now I think 'good design'
is when the page doesn't irritate the living f*ck out of me." (JWZ)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, iwata.aya@fujitsu.com, tsunakawa.takay@fujitsu.com, horikyota.ntt@gmail.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-Reply-To: <20210401190536.GA29620@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox