From: Bruce Momjian <bruce@momjian.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Hannu Krosing <hannuk@google.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: torikoshia <torikoshia@oss.nttdata.com>
Cc: Atsushi Torikoshi <atorik@gmail.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Evgeny Efimkin <efimkin@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Date: Wed, 7 Apr 2021 22:42:29 -0400
Message-ID: <20210408024229.GJ24239@momjian.us> (raw)
In-Reply-To: <20210408023808.gp75kbrli5df7wkd@nol>
References: <1646131.1617826550@sss.pgh.pa.us>
<20210407202255.GD24239@momjian.us>
<20210407215625.syzdpwew4j47hhgl@nol>
<20210407223840.GE24239@momjian.us>
<1730584.1617836485@sss.pgh.pa.us>
<20210407233835.GF24239@momjian.us>
<20210408004748.mhqds3v3nij35ihw@nol>
<20210408005402.GG24239@momjian.us>
<20210408023101.GI24239@momjian.us>
<20210408023808.gp75kbrli5df7wkd@nol>
On Thu, Apr 8, 2021 at 10:38:08AM +0800, Julien Rouhaud wrote:
> On Wed, Apr 07, 2021 at 10:31:01PM -0400, Bruce Momjian wrote:
> > On Wed, Apr 7, 2021 at 08:54:02PM -0400, Bruce Momjian wrote:
> > > > Unless I'm missing something this will output the query id in the next log
> > > > line? The new code should be added before the newline is output, and the comma
> > > > should also be output before the queryid.
> > >
> > > Yes, correct, updated patch attached.
> >
> > Patch applied.
>
> Thanks! And I agree with using query_id in the new field names while keeping
> queryid for pg_stat_statements to avoid unnecessary query breakage.
I think we need more feedback from the group. Do people agree with the
idea above? The question is what to call:
GUC compute_queryid
pg_stat_activity.queryid
pg_stat_statements.queryid
using "queryid" or "query_id", and do they have to match?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, rjuju123@gmail.com, tgl@sss.pgh.pa.us, nitinjadhavpostgres@gmail.com, alvherre@alvh.no-ip.org, hannuk@google.com, robertmhaas@gmail.com, pavel.stehule@gmail.com, michael@paquier.xyz, torikoshia@oss.nttdata.com, atorik@gmail.com, tatsuro.yamada.tf@nttcom.co.jp, tomas.vondra@2ndquadrant.com, efimkin@yandex-team.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
In-Reply-To: <20210408024229.GJ24239@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox