From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: SQL-standard function body
Date: Thu, 8 Apr 2021 19:19:36 +0800
Message-ID: <20210408111936.bbrjonwadodhaswf@nol> (raw)
In-Reply-To: <1825656.1617865082@sss.pgh.pa.us>
References: <01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com>
<1646498.1617826937@sss.pgh.pa.us>
<YG54YggzyPrTFE+e@paquier.xyz>
<1819824.1617858962@sss.pgh.pa.us>
<20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de>
<20210408054626.gyz3al2j5r5kzhrt@nol>
<1821917.1617861925@sss.pgh.pa.us>
<20210408063320.eciql3ay52ge5flz@alap3.anarazel.de>
<20210408064036.fwf2o6stviilbocf@nol>
<1825656.1617865082@sss.pgh.pa.us>
On Thu, Apr 08, 2021 at 02:58:02AM -0400, Tom Lane wrote:
> Julien Rouhaud <rjuju123@gmail.com> writes:
> > On Wed, Apr 07, 2021 at 11:33:20PM -0700, Andres Freund wrote:
> >> Nothing special, really. Surprised the BF doesn't see it:
>
> > Is think this is because the buildfarm client is running installcheck for the
> > contribs rather than check, and pg_stat_statements/Makefile has:
> > # Disabled because these tests require "shared_preload_libraries=pg_stat_statements",
> > # which typical installcheck users do not have (e.g. buildfarm clients).
> > NO_INSTALLCHECK = 1
>
> No, because if that were the explanation then we'd be getting no
> buildfarm coverage at all for for pg_stat_statements. Which aside
> from being awful contradicts the results at coverage.postgresql.org.
Is there any chance that coverage.postgresql.org isn't backed by the buildfarm
client but a plain make check-world or something like that?
> I think Andres has the right idea that there's some more-subtle
> variation in the test conditions, but (yawn) too tired to look
> into it right now.
I tried to look at some force-parallel-mode animal, like mantid, and I don't
see any evidence of pg_stat_statements being run by a "make check", and only a
few contrib modules seem to have an explicit check phase. However, looking at
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mantid&dt=2021-04-08%2007%3A07%3A05
I see
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=mantid&dt=2021-04-08%2007%3A07%3A0...:
[...]
make -C pg_stat_statements installcheck
make[1]: Entering directory `/u1/tac/build-farm-11/buildroot/HEAD/pgsql.build/contrib/pg_stat_statements'
make[1]: Nothing to be done for `installcheck'.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, jcasanov@systemguards.com.ec, pgsql-hackers@lists.postgresql.org
Subject: Re: SQL-standard function body
In-Reply-To: <20210408111936.bbrjonwadodhaswf@nol>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox