From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: yuzuko <yuzukohosoya@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: David Steele <david@pgmasters.net>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@lists.postgresql.org, Greg Stark <stark@mit.edu>
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Date: Thu, 8 Apr 2021 17:56:25 -0400
Message-ID: <20210408215625.GA17048@alvherre.pgsql> (raw)
In-Reply-To: <20210408213051.GL6592@telsasoft.com>
On 2021-Apr-08, Justin Pryzby wrote:
> commit 0827e8af70f4653ba17ed773f123a60eadd9f9c9
> | This also introduces necessary reloptions support for partitioned tables
> | (autovacuum_enabled, autovacuum_analyze_scale_factor,
> | autovacuum_analyze_threshold). It's unclear how best to document this
> | aspect.
>
> At least this part needs to be updated - see also ed62d3737.
>
> doc/src/sgml/ref/create_table.sgml- The storage parameters currently
> doc/src/sgml/ref/create_table.sgml- available for tables are listed below.
> ...
> doc/src/sgml/ref/create_table.sgml: Specifying these parameters for partitioned tables is not supported,
> doc/src/sgml/ref/create_table.sgml- but you may specify them for individual leaf partitions.
Ah, thanks for pointing it out. How about the attached?
This new bit reads weird:
+ Most parameters are not supported on partitioned tables, with exceptions
+ noted below; you may specify them for individual leaf partitions.
Maybe "Most parameters are not supported on partitioned tables, with
exceptions noted below; you may specify others for individual leaf
partitions."
--
Álvaro Herrera 39°49'30"S 73°17'W
Attachments:
[text/x-diff] 0001-document-reloptions-for-partitioned-tables.patch (2.3K, ../20210408215625.GA17048@alvherre.pgsql/2-0001-document-reloptions-for-partitioned-tables.patch)
download | inline diff:
From 37a829ec7b9c46acbbdb02f231288e39d22fcd04 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 8 Apr 2021 17:53:22 -0400
Subject: [PATCH] document reloptions for partitioned tables
---
doc/src/sgml/ref/create_table.sgml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgmlindex 44e50620fd..3cf355cc8d 100644--- a/doc/src/sgml/ref/create_table.sgml+++ b/doc/src/sgml/ref/create_table.sgml@@ -1369,8 +1369,8 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
If a table parameter value is set and the
equivalent <literal>toast.</literal> parameter is not, the TOAST table
will use the table's parameter value.
- Specifying these parameters for partitioned tables is not supported,- but you may specify them for individual leaf partitions.+ Most parameters are not supported on partitioned tables, with exceptions+ noted below; you may specify them for individual leaf partitions.
</para>
<variablelist>
@@ -1452,6 +1452,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
If true, the autovacuum daemon will perform automatic <command>VACUUM</command>
and/or <command>ANALYZE</command> operations on this table following the rules
discussed in <xref linkend="autovacuum"/>.
+ This parameter is supported on partitioned tables.
If false, this table will not be autovacuumed, except to prevent
transaction ID wraparound. See <xref linkend="vacuum-for-wraparound"/> for
more about wraparound prevention.
@@ -1576,6 +1577,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<para>
Per-table value for <xref linkend="guc-autovacuum-analyze-threshold"/>
parameter.
+ This parameter is supported on partitioned tables.
</para>
</listitem>
</varlistentry>
@@ -1591,6 +1593,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<para>
Per-table value for <xref linkend="guc-autovacuum-analyze-scale-factor"/>
parameter.
+ This parameter is supported on partitioned tables.
</para>
</listitem>
</varlistentry>
--
2.20.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pryzby@telsasoft.com, yuzukohosoya@gmail.com, tomas.vondra@enterprisedb.com, david@pgmasters.net, horikyota.ntt@gmail.com, daniel@yesql.se, amitlangote09@gmail.com, masahiko.sawada@2ndquadrant.com, laurenz.albe@cybertec.at, stark@mit.edu
Subject: Re: Autovacuum on partitioned table (autoanalyze)
In-Reply-To: <20210408215625.GA17048@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox