pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Julien Rouhaud <rjuju123@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Tue, 11 May 2021 17:41:06 +0800
Message-ID: <20210511094106.tqocsdmoefvu5lpu@nol> (raw)
In-Reply-To: <CABUevEy7pFmw4NeEjpjGhAOKrOaTDVqdw3Z9KshvFKPG=iy3kA@mail.gmail.com>
References: <20210426174331.GA19401@alvherre.pgsql>
	<20210426181408.3j6kkzpxnadpwptv@alap3.anarazel.de>
	<2295572.1619461260@sss.pgh.pa.us>
	<20210426183745.4gd2s5qra6mlxfto@alap3.anarazel.de>
	<20210427062504.ofz3rgedbrl5bep2@nol>
	<YJoeXcrwe1EDmqKT@paquier.xyz>
	<20210511073539.vw4m46vvbqhiwnz5@nol>
	<4f0929bf-c690-f2be-a050-a69a47a79651@oss.nttdata.com>
	<20210511085219.knbimwnsq45cloxm@nol>
	<CABUevEy7pFmw4NeEjpjGhAOKrOaTDVqdw3Z9KshvFKPG=iy3kA@mail.gmail.com>

On Tue, May 11, 2021 at 10:59:51AM +0200, Magnus Hagander wrote:
> 
> That doesn't fundamentally make it impossible, you just have to add it
> to the list of variables being copied over, wouldn't you? See
> save_backend_variables()

Yes, I agree, and that's what I meant by "explicitly handled".  The thing is
that I don't know if that's the best way to go, as it doesn't solve the "is it
actually enabled" and/or "which implementation is used".  At least the patch I
sent, although it's totally a hack, let you know if compute_query_id is enabled
or not.  I'm fine with implementing it that way, but only if there's a
consensus.





view thread (158+ messages)  latest in thread

Message-ID: <20210511094106.tqocsdmoefvu5lpu@nol>
Permalink:  ../20210511094106.tqocsdmoefvu5lpu@nol/
Also on:    postgresql.org/message-id/20210511094106.tqocsdmoefvu5lpu@nol

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: rjuju123@gmail.com, magnus@hagander.net, masao.fujii@oss.nttdata.com, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: compute_query_id and pg_stat_statements
  In-Reply-To: <20210511094106.tqocsdmoefvu5lpu@nol>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox