From: Julien Rouhaud <rjuju123@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Wed, 12 May 2021 14:10:49 +0800
Message-ID: <20210512061049.dykngnivdoesquxb@nol> (raw)
In-Reply-To: <CAFj8pRB0isJLNBcom3czQCC3g7S6ZFc59jdPfps00r8j=dVZbg@mail.gmail.com>
References: <20210511105249.2obdq32n6tc5gyqd@nol>
<20210512.110836.2162399537656469720.horikyota.ntt@gmail.com>
<20210512024201.ak3ofofakn2ymhiv@nol>
<20210512.143335.1053382893089496881.horikyota.ntt@gmail.com>
<CAFj8pRB0isJLNBcom3czQCC3g7S6ZFc59jdPfps00r8j=dVZbg@mail.gmail.com>
On Wed, May 12, 2021 at 07:49:13AM +0200, Pavel Stehule wrote:
>
> > Ah, I missed that case. And we are wanting to use pg_stat_statements
> > with (almost) zero-config? How about the following behavior?
> >
> >
> Until now, the pg_stat_statements was zero-config. So the change is not
> user friendly.
Apart from configuring shared_preload_libraries, but agreed.
> The idea so pg_stat_statements requires enabled computed_query_id is not
> good. There should be dependency only on the queryid column.
I agree that requiring to change compute_query_id when you already added
pg_stat_statements in shared_preload_libraries isn't good, and the patch I sent
yesterday would fix that.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, pavel.stehule@gmail.com, horikyota.ntt@gmail.com, magnus@hagander.net, masao.fujii@oss.nttdata.com, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: compute_query_id and pg_stat_statements
In-Reply-To: <20210512061049.dykngnivdoesquxb@nol>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox