pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Christoph Berg <myon@debian.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Date: Thu, 13 May 2021 13:51:07 -0400
Message-ID: <20210513175107.GF20766@tamriel.snowman.net> (raw)
In-Reply-To: <20210513174115.GN11075@momjian.us>
References: <20210513015700.fp33q5rfvwl2ahfx@nol>
<20210513030652.GB11075@momjian.us>
<20210513031613.j47baglf6xl3mgbs@nol>
<20210513033332.GF11075@momjian.us>
<20210513040342.fouh7ryglrfgxglu@nol>
<e3d3e3e5-0b33-5165-9121-6e770830e609@oss.nttdata.com>
<d7a5dd14-27a9-931e-3901-02319cef669b@dunslane.net>
<1576471.1620926236@sss.pgh.pa.us>
<20210513173327.GD20766@tamriel.snowman.net>
<20210513174115.GN11075@momjian.us>
Greetings,
* Bruce Momjian (bruce@momjian.us) wrote:
> On Thu, May 13, 2021 at 01:33:27PM -0400, Stephen Frost wrote:
> > I'm coming around to have a similar feeling. While having an
> > alternative query ID might be useful, I have a hard time seeing it as
> > likely to be a hugely popular feature that is worth a lot of users
> > complaining (as we've seen already, multiple times, before even getting
> > to beta...) that things aren't working anymore. That we can't figure
> > out which libraries to load automatically based on what extensions have
> > been installed and therefore make everyone have to change
> > shared_preload_libraries isn't a good thing and requiring additional
> > configuration for extremely common extensions like pg_stat_statements is
> > making it worse.
>
> Would someone please explain what is wrong with what is in the tree
> now, except that it needs additional warnings about misconfiguration?
> Requiring two postgresql.conf changes instead of one doesn't seem like a
> valid complaint to me, especially if the warnings are in place and the
> release notes mention it.
Will you be updating pg_upgrade to detect and throw a warning during
check in the event that it discovers a broken config?
If not, then I don't think you're correct in arguing that this need for
additional configuration isn't a valid complaint.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
view thread (158+ messages) latest in thread
Message-ID: <20210513175107.GF20766@tamriel.snowman.net> Permalink: ../20210513175107.GF20766@tamriel.snowman.net/ Also on: postgresql.org/message-id/20210513175107.GF20766@tamriel.snowman.net ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients using the --to and --cc options: reply via email To: pgsql-hackers@postgresql.org Cc: sfrost@snowman.net, bruce@momjian.us, tgl@sss.pgh.pa.us, andrew@dunslane.net, masao.fujii@oss.nttdata.com, rjuju123@gmail.com, pavel.stehule@gmail.com, horikyota.ntt@gmail.com, magnus@hagander.net, michael@paquier.xyz, andres@anarazel.de, alvherre@alvh.no-ip.org, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org Subject: Re: compute_query_id and pg_stat_statements In-Reply-To: <20210513175107.GF20766@tamriel.snowman.net> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox