From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Deparsing rewritten query
Date: Sun, 27 Jun 2021 23:21:37 +0800
Message-ID: <20210627152137.3rwfmfswwfrxmlsr@nol> (raw)
In-Reply-To: <8085.1624806845@sss.pgh.pa.us>
References: <20210627041138.zklczwmu3ms4ufnk@nol>
<3176554.1624804492@sss.pgh.pa.us>
<20210627150343.zslwnw7g564f2zz4@nol>
<8085.1624806845@sss.pgh.pa.us>
On Sun, Jun 27, 2021 at 11:14:05AM -0400, Tom Lane wrote:
> Julien Rouhaud <rjuju123@gmail.com> writes:
>
> > Agreed. One the other hand having such a function in core may ensure that any
> > significant change in those area will keep an API to retrieve the final query
> > representation.
>
> My point is precisely that I'm unwilling to make such a promise.
>
> I do not buy that this capability is worth very much, given that
> we've gotten along fine without it for twenty-plus years. If you
> want to have it as an internal, might-change-at-any-time API,
> that seems all right.
I'm totally fine with a might-change-at-any-time API, but not with a
might-disappear-at-anytime API. If exposing get_query_def() can become
virtually useless in a few releases with no hope to get required in-core change
for retrieving the final query representation, I agree this we can stop the
discussion here.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Deparsing rewritten query
In-Reply-To: <20210627152137.3rwfmfswwfrxmlsr@nol>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox