pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Removed extra memory allocations from create_list_bounds
Date: Mon, 5 Jul 2021 12:03:33 -0500
Message-ID: <20210705170333.GA21248@telsasoft.com> (raw)
In-Reply-To: <CAApHDvpouaAv6P+UHbwZ1OL=z1sBcf5vuMJXGauhBZZMEAHb2w@mail.gmail.com>
References: <CAMm1aWYFTqEio3bURzZh47jveiHRwgQTiSDvBORczNEz2duZ1Q@mail.gmail.com>
	<20210516170029.GB373@telsasoft.com>
	<CALNJ-vS4g3QNmPe8WcgBmJQOzS0K_OAujW_1T0J2JXqpBQoBFw@mail.gmail.com>
	<CAMm1aWYr9=qPCTeNzVCEbF=Nr=RLSnt_vdCDTm9VjLS5L5JuOw@mail.gmail.com>
	<20210517150310.GG373@telsasoft.com>
	<CAMm1aWb0KSOCHexbaeit7gy_p4Uhs18EWyBdPyis4bfw4ids7A@mail.gmail.com>
	<CAApHDvpouaAv6P+UHbwZ1OL=z1sBcf5vuMJXGauhBZZMEAHb2w@mail.gmail.com>

Also, if you're going to remove the initializations here, maybe you'd also
change i and j to C99 "for" declarations like "for (int i=0, j=0; ...)"

-       PartitionListValue **all_values = NULL;
-       ListCell   *cell;
-       int                     i = 0;
-       int                     ndatums = 0;
+       PartitionListValue *all_values;
+       int                     i;
+       int                     j;
+       int                     ndatums;

Same in get_non_null_list_datum_count()

-- 
Justin





view thread (20+ messages)  latest in thread

Message-ID: <20210705170333.GA21248@telsasoft.com>
Permalink:  ../20210705170333.GA21248@telsasoft.com/
Also on:    postgresql.org/message-id/20210705170333.GA21248@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, dgrowleyml@gmail.com, nitinjadhavpostgres@gmail.com, zyu@yugabyte.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Removed extra memory allocations from create_list_bounds
  In-Reply-To: <20210705170333.GA21248@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox