From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Dave Cramer <davecramer@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: Thu, 29 Jul 2021 15:06:45 -0400
Message-ID: <20210729190645.GS9600@momjian.us> (raw)
In-Reply-To: <202107291743.pqlj3s2uilfu@alvherre.pgsql>
References: <20210729163448.GP9600@momjian.us>
<202107291743.pqlj3s2uilfu@alvherre.pgsql>
On Thu, Jul 29, 2021 at 01:43:09PM -0400, Álvaro Herrera wrote:
> On 2021-Jul-29, Bruce Momjian wrote:
>
> > + If the old cluster used extensions, whether from
> > + <filename>contrib</filename> or some other source, it used
> > + shared object files (or DLLs) to implement these extensions, e.g.,
> > + <filename>pgcrypto.so</filename>. Now, shared object files matching
> > + the new server binary must be installed in the new cluster, usually
> > + via operating system commands. Do not load the schema definitions,
> > + e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> > + will be copied from the old cluster. (Extensions should be upgraded
> > + later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I propose this:
>
> <para>
> If the old cluster used shared-object files (or DLLs) for extensions
> or other loadable modules, install recompiled versions of those files
> onto the new cluster.
> Do not install the extension themselves (i.e., do not run
> <command>CREATE EXTENSION</command>), because extension definitions
> will be carried forward from the old cluster.
> </para>
>
> <para>
> Extensions can be upgraded after pg_upgrade completes using
> <command>ALTER EXTENSION ... UPGRADE</command>, on a per-database
> basis.
> </para>
>
> I suggest " ... for extensions or other loadable modules" because
> loadable modules aren't necessarily for extensions. Also, it's
> perfectly possible to have extension that don't have a loadable module.
Yes, good point.
> I suggest "extension definitions ... carried forward" instead of
> "extensions ... copied" (your proposed text) to avoid the idea that
> files are copied; use it instead of "schema definitions ... upgraded"
> (the current docs) to avoid the idea that they are actually upgraded;
> also, "schema definition" seems a misleading term to use here.
I used the term "duplicated".
> I suggest "can be upgraded" rather than "should be upgraded" because
> we're not making a recommendation, merely stating the fact that it is
> possible to do so.
Agreed. Most extensions don't have updates between major versions.
> I suggest using the imperative mood, to be consistent with the
> surrounding text. (Applies to the first para; the second para is
> informative.)
OK.
> I haven't seen it mentioned in the thread, but I think the final phrase
> of this <step> should be a separate step,
>
> <step>
> <title>Copy custom full-text search files</title>
> <para>
> Copy any custom full text search file (dictionary, synonym, thesaurus,
> stop word list) to the new server.
> </para>
> </step>
>
> While this is closely related to extensions, it's completely different.
Agreed. See attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:pg_upgrade.diff (text/x-diff, 2.2K) downloaddiff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgmlindex a83c63cd98..0a71465805 100644--- a/doc/src/sgml/ref/pgupgrade.sgml+++ b/doc/src/sgml/ref/pgupgrade.sgml@@ -299,17 +299,27 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster- into the new cluster, e.g., <filename>pgcrypto.so</filename>,- whether they are from <filename>contrib</filename>- or some other source. Do not install the schema definitions, e.g.,- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded- from the old cluster.- Also, any custom full text search files (dictionary, synonym,- thesaurus, stop words) must also be copied to the new cluster.+ Many extensions and custom modules, whether from+ <filename>contrib</filename> or another source, use shared object+ files (or DLLs), e.g., <filename>pgcrypto.so</filename>. If the old+ cluster used these, shared object files matching the new server binary+ must be installed in the new cluster, usually via operating system+ commands. Do not load the schema definitions, e.g., <command>CREATE+ EXTENSION pgcrypto</command>, because these will be duplicated from+ the old cluster. (Extensions with available updates can be processed+ later using <literal>ALTER EXTENSION ... UPDATE</literal>.)+ </para>+ </step>++ <step>+ <title>Copy custom full-text search files</title>++ <para>+ Copy any custom full text search files (dictionary, synonym,+ thesaurus, stop words) from the old to the new cluster.
</para>
</step>
@@ -494,10 +504,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, alvherre@alvh.no-ip.org, davecramer@gmail.com, david.g.johnston@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
In-Reply-To: <20210729190645.GS9600@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox