pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
Cc: masao.fujii@oss.nttdata.com, pgsql-hackers@postgresql.org, rjuju123@gmail.com, tgl@sss.pgh.pa.us, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Improve logging when using Huge Pages
Date: Thu, 21 Oct 2021 21:38:15 -0500
Message-ID: <20211022023815.GI741@telsasoft.com> (raw)
In-Reply-To: <TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
References: <TU4PR8401MB1152B1A4158D609472ABD51DEEA09@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<80872660-ad16-3040-0a25-bd741faa5fc0@oss.nttdata.com>
	<20210922002322.GS831@telsasoft.com>
	<20210927.114023.1519840069762071193.horikyota.ntt@gmail.com>
	<TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>

+               ereport(LOG, (errmsg("Anonymous shared memory was allocated %s huge pages.", with_hugepages ? "with" : "without")));

You shouldn't break a sentence into pieces like this, since it breaks
translation.  You don't want an untranslated "without" to appear in the middle
of the translated message.

There are cases where a component *shouldn't* be translated, like this one:
where "numeric" should not be translated.

src/backend/utils/adt/numeric.c:                                         errmsg("invalid input syntax for type %s: \"%s\"",
src/backend/utils/adt/numeric.c-                                                        "numeric", str)));

-- 
Justin





view thread (93+ messages)  latest in thread

Message-ID: <20211022023815.GI741@telsasoft.com>
Permalink:  ../20211022023815.GI741@telsasoft.com/
Also on:    postgresql.org/message-id/20211022023815.GI741@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, noriyoshi.shinoda@hpe.com, horikyota.ntt@gmail.com
  Subject: Re: Improve logging when using Huge Pages
  In-Reply-To: <20211022023815.GI741@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox