pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: make tuplestore helper function
Date: Tue, 2 Nov 2021 15:23:53 -0500
Message-ID: <20211102202353.GG17618@telsasoft.com> (raw)
In-Reply-To: <CAAKRu_azyd1Z3W_r7Ou4sorTjRCs+PxeHw1CWJeXKofkE6TuZg@mail.gmail.com>
References: <CAAKRu_azyd1Z3W_r7Ou4sorTjRCs+PxeHw1CWJeXKofkE6TuZg@mail.gmail.com>

Several places have a conditional value for the first argument (randomAccess),
but your patch changes the behavior to a constant "true".  I didn't review the
patch beyond that.

> @@ -740,18 +724,14 @@ pg_prepared_statement(PG_FUNCTION_ARGS)
> -	tupstore =
> -		tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> @@ -2701,42 +2701,13 @@ pg_hba_file_rules(PG_FUNCTION_ARGS)
> -	tuple_store =
> -		tuplestore_begin_heap(rsi->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> @@ -4799,31 +4797,8 @@ pg_timezone_names(PG_FUNCTION_ARGS)
> -	randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> -	tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);

> @@ -575,38 +575,12 @@ pg_ls_dir_1arg(PG_FUNCTION_ARGS)
> -	randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> -	tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);

> @@ -1170,17 +1154,12 @@ pg_cursor(PG_FUNCTION_ARGS)
> -	tupstore =
> -		tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> +++ b/src/backend/utils/fmgr/funcapi.c
> +	tupstore = tuplestore_begin_heap(true, false, maxKBytes);

-- 
Justin





view thread (23+ messages)  latest in thread

Message-ID: <20211102202353.GG17618@telsasoft.com>
Permalink:  ../20211102202353.GG17618@telsasoft.com/
Also on:    postgresql.org/message-id/20211102202353.GG17618@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, melanieplageman@gmail.com, andres@anarazel.de, alvherre@alvh.no-ip.org
  Subject: Re: make tuplestore helper function
  In-Reply-To: <20211102202353.GG17618@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox