pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: windows cfbot failing: my_perl
Date: Fri, 26 Aug 2022 16:32:15 -0400
Message-ID: <2021463.1661545935@sss.pgh.pa.us> (raw)
In-Reply-To: <20220826202830.26fn67xocpryulrj@awork3.anarazel.de>
References: <20220826115546.GE2342@telsasoft.com>
	<20220826132151.sj6pieswskq4vp4z@awork3.anarazel.de>
	<20220826134047.vr3bppkwqhy5ppn3@awork3.anarazel.de>
	<20220826142700.fecymkdgdelktrlp@awork3.anarazel.de>
	<CAFBsxsFew_-eaa6geJsR5WcRLeQ9afrPg4rZL59g=3GGu5g_+Q@mail.gmail.com>
	<20220826144740.ff3berqoeoi6lnd4@awork3.anarazel.de>
	<20220826202830.26fn67xocpryulrj@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Tom, Ilmari, you seem to have hacked on this stuff most (not so) recently. Do
> you have a better suggestion than moving the mb/pg_wchar.h include out of
> plperl_helpers.h as I suggest below?

I agree with the conclusion that we'd better #include all our own
headers before any of Perl's.  No strong opinions about which
rearrangement is least ugly --- but let's add some comments about
that requirement.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <2021463.1661545935@sss.pgh.pa.us>
Permalink:  ../2021463.1661545935@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2021463.1661545935@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, john.naylor@enterprisedb.com, ilmari@ilmari.org, pryzby@telsasoft.com, john.naylor@postgresql.org, thomas.munro@gmail.com
  Subject: Re: windows cfbot failing: my_perl
  In-Reply-To: <2021463.1661545935@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox