public inbox for [email protected]  
help / color / mirror / Atom feed
From: Julien Rouhaud <[email protected]>
To: Dilip Kumar <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Error "initial slot snapshot too large" in create replication slot
Date: Wed, 12 Jan 2022 18:38:55 +0800
Message-ID: <20220112103855.ib4455yyebaxkuwp@jrouhaud> (raw)
In-Reply-To: <CAFiTN-ui+vtbUq_-3+SzT4KU_=iAJz7_-en+_tnPz-p34h76mQ@mail.gmail.com>
References: <[email protected]>
	<CAFiTN-uynCwLm+r_eHH57SftumTPuU+qSr0mxF6hQDUOz0r+BA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAFiTN-sARczQgig5riHUAQsTYZxqF-iP70gBFfq8E3n0oHjFjg@mail.gmail.com>
	<CAFiTN-sVLdkdBzJFr2+b9iPvQ_MfWYQ2mhDAXP=cpbmyw-evNg@mail.gmail.com>
	<CAFiTN-ui+vtbUq_-3+SzT4KU_=iAJz7_-en+_tnPz-p34h76mQ@mail.gmail.com>

Hi,

On Tue, Nov 02, 2021 at 04:40:39PM +0530, Dilip Kumar wrote:
> 
> I have fixed this, the updated patch is attached.

The cfbot reports that this patch doesn't compile:
https://cirrus-ci.com/task/5642000073490432?logs=build

[03:01:24.477] snapbuild.c: In function ‘SnapBuildInitialSnapshot’:
[03:01:24.477] snapbuild.c:587:2: error: ‘newsubxcnt’ undeclared (first use in this function); did you mean ‘newsubxip’?
[03:01:24.477]   587 |  newsubxcnt = 0;
[03:01:24.477]       |  ^~~~~~~~~~
[03:01:24.477]       |  newsubxip
[03:01:24.477] snapbuild.c:587:2: note: each undeclared identifier is reported only once for each function it appears in
[03:01:24.477] snapbuild.c:535:8: warning: unused variable ‘maxxidcnt’ [-Wunused-variable]
[03:01:24.477]   535 |  int   maxxidcnt;
[03:01:24.477]       |        ^~~~~~~~~

Could you send a new version?  In the meantime I will switch the patch to
Waiting on Author.






view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Error "initial slot snapshot too large" in create replication slot
  In-Reply-To: <20220112103855.ib4455yyebaxkuwp@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox