public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 17/18] *an old and "deleted [has] happened"
3+ messages / 3 participants
[nested] [flat]
* [PATCH 17/18] *an old and "deleted [has] happened"
@ 2021-02-06 21:17 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Justin Pryzby @ 2021-02-06 21:17 UTC (permalink / raw)
Heikki missed this in 6b387179baab8d0e5da6570678eefbe61f3acc79
---
doc/src/sgml/protocol.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 3763b4b995..a51f2c9920 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -6928,8 +6928,8 @@ Delete
</term>
<listitem>
<para>
- Identifies the following TupleData message as a old tuple.
- This field is present if the table in which the delete has
+ Identifies the following TupleData message as an old tuple.
+ This field is present if the table in which the delete
happened has REPLICA IDENTITY set to FULL.
</para>
</listitem>
--
2.17.0
--lc9FT7cWel8HagAv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0018-doc-review-for-pg_stat_progress_create_index.patch"
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Error "initial slot snapshot too large" in create replication slot
@ 2022-01-12 10:38 Julien Rouhaud <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Julien Rouhaud @ 2022-01-12 10:38 UTC (permalink / raw)
To: Dilip Kumar <[email protected]>; +Cc: Kyotaro Horiguchi <[email protected]>; PostgreSQL Hackers <[email protected]>
Hi,
On Tue, Nov 02, 2021 at 04:40:39PM +0530, Dilip Kumar wrote:
>
> I have fixed this, the updated patch is attached.
The cfbot reports that this patch doesn't compile:
https://cirrus-ci.com/task/5642000073490432?logs=build
[03:01:24.477] snapbuild.c: In function ‘SnapBuildInitialSnapshot’:
[03:01:24.477] snapbuild.c:587:2: error: ‘newsubxcnt’ undeclared (first use in this function); did you mean ‘newsubxip’?
[03:01:24.477] 587 | newsubxcnt = 0;
[03:01:24.477] | ^~~~~~~~~~
[03:01:24.477] | newsubxip
[03:01:24.477] snapbuild.c:587:2: note: each undeclared identifier is reported only once for each function it appears in
[03:01:24.477] snapbuild.c:535:8: warning: unused variable ‘maxxidcnt’ [-Wunused-variable]
[03:01:24.477] 535 | int maxxidcnt;
[03:01:24.477] | ^~~~~~~~~
Could you send a new version? In the meantime I will switch the patch to
Waiting on Author.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Error "initial slot snapshot too large" in create replication slot
@ 2022-01-17 03:57 Dilip Kumar <[email protected]>
parent: Julien Rouhaud <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Dilip Kumar @ 2022-01-17 03:57 UTC (permalink / raw)
To: Julien Rouhaud <[email protected]>; +Cc: Kyotaro Horiguchi <[email protected]>; PostgreSQL Hackers <[email protected]>
On Wed, Jan 12, 2022 at 4:09 PM Julien Rouhaud <[email protected]> wrote:
> Hi,
>
> On Tue, Nov 02, 2021 at 04:40:39PM +0530, Dilip Kumar wrote:
> >
> > I have fixed this, the updated patch is attached.
>
> The cfbot reports that this patch doesn't compile:
> https://cirrus-ci.com/task/5642000073490432?logs=build
>
> [03:01:24.477] snapbuild.c: In function ‘SnapBuildInitialSnapshot’:
> [03:01:24.477] snapbuild.c:587:2: error: ‘newsubxcnt’ undeclared (first
> use in this function); did you mean ‘newsubxip’?
> [03:01:24.477] 587 | newsubxcnt = 0;
> [03:01:24.477] | ^~~~~~~~~~
> [03:01:24.477] | newsubxip
> [03:01:24.477] snapbuild.c:587:2: note: each undeclared identifier is
> reported only once for each function it appears in
> [03:01:24.477] snapbuild.c:535:8: warning: unused variable ‘maxxidcnt’
> [-Wunused-variable]
> [03:01:24.477] 535 | int maxxidcnt;
> [03:01:24.477] | ^~~~~~~~~
>
> Could you send a new version? In the meantime I will switch the patch to
> Waiting on Author.
>
Thanks for notifying, I will work on this and send the update patch soon.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-01-17 03:57 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 21:17 [PATCH 17/18] *an old and "deleted [has] happened" Justin Pryzby <[email protected]>
2022-01-12 10:38 Re: Error "initial slot snapshot too large" in create replication slot Julien Rouhaud <[email protected]>
2022-01-17 03:57 ` Re: Error "initial slot snapshot too large" in create replication slot Dilip Kumar <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox