pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>
Cc: Japin Li <japinli@hotmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: smithpb2250@gmail.com <smithpb2250@gmail.com>
Cc: david.zhang@highgo.ca <david.zhang@highgo.ca>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support tab completion for upper character inputs in psql
Date: Wed, 19 Jan 2022 16:59:20 +0800
Message-ID: <20220119085920.mzmkzed5vl7k4iwv@jrouhaud> (raw)
In-Reply-To: <3547066.1642272686@sss.pgh.pa.us>
References: <OS0PR01MB61136721363BD08576725F22FB089@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<80b093ae-88bd-8d8a-68b9-b535a3ab11be@enterprisedb.com>
	<OS0PR01MB61137C7B2B09C0431415B9DBFBD69@OS0PR01MB6113.jpnprd01.prod.outlook.com>
	<54bd7839-f463-ef03-f2d2-ccb8184b9b27@enterprisedb.com>
	<1068530.1641480996@sss.pgh.pa.us>
	<TYCPR01MB6128BD8EA1529F4270114C18FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
	<MEYP282MB1669EAF2183E67EAF86F7F61B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
	<TYCPR01MB6128D4933189A74AAD326F98FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com>
	<c7fb9ad1-0b77-eda5-0055-02ee472e3a4a@enterprisedb.co! m>
	<3547066.1642272686@sss.pgh.pa.us>

Hi,

On Sat, Jan 15, 2022 at 01:51:26PM -0500, Tom Lane wrote:
> 
> I spent some time looking at this patch.  I'm not very happy with it,
> for two reasons:
> [...]

On top of that the patch doesn't apply anymore:

http://cfbot.cputube.org/patch_36_2979.log
=== Applying patches on top of PostgreSQL commit ID 5987feb70b5bbb1fc4e64d433f490df08d91dd45 ===
=== applying patch ./v11-0001-Support-tab-completion-with-a-query-result-for-u.patch
patching file src/bin/psql/t/010_tab_completion.pl
Hunk #1 FAILED at 41.
Hunk #2 succeeded at 150 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file src/bin/psql/t/010_tab_completion.pl.rej

I'm switching the CF entry to Waiting on Author.





view thread (54+ messages)  latest in thread

Message-ID: <20220119085920.mzmkzed5vl7k4iwv@jrouhaud>
Permalink:  ../20220119085920.mzmkzed5vl7k4iwv@jrouhaud/
Also on:    postgresql.org/message-id/20220119085920.mzmkzed5vl7k4iwv@jrouhaud

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: rjuju123@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, tanghy.fnst@fujitsu.com, japinli@hotmail.com, horikyota.ntt@gmail.com, laurenz.albe@cybertec.at, smithpb2250@gmail.com, david.zhang@highgo.ca, pgsql-hackers@lists.postgresql.org
  Subject: Re: Support tab completion for upper character inputs in psql
  In-Reply-To: <20220119085920.mzmkzed5vl7k4iwv@jrouhaud>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox