pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A test for replay of regression tests
Date: Fri, 21 Jan 2022 11:48:27 -0800
Message-ID: <20220121194827.7eau4ulhrfol3npd@alap3.anarazel.de> (raw)
In-Reply-To: <CA+hUKG+yxxnFWvp4h_HgJvptQ2uKE4aKtDd7e5nmr61Soe6a2Q@mail.gmail.com>
References: <CA+hUKGLnJoeSqtp0tNyFj2GUYaNgbCQ3KTZqCfFH7QY2+Ojcdg@mail.gmail.com>
	<20211209213605.6lwb7o2kzdla34qk@alap3.anarazel.de>
	<CA+hUKGJd_BSh_6hNCDPfvEcRDk6g7gYxybEvVuGgFWe+D3useA@mail.gmail.com>
	<YbmsZbEO1QGMymNF@paquier.xyz>
	<YbqG0DsKGRBnY/4t@paquier.xyz>
	<CA+hUKGK-+mg6RWiDu0JudF6jWeL5+gPmi8EKUm1eAzmdbwiE_A@mail.gmail.com>
	<CA+hUKG+GBC-6QhOKt6Y7ccrXSjbRHB7Di295=0rAGhE7a7hSrQ@mail.gmail.com>
	<CA+hUKGLneD+q+E7upHGwn41KGvbxhsKbJ+M-y9nvv7_Xjv8Qog@mail.gmail.com>
	<20220114234947.av4kkhuj7netsy5r@alap3.anarazel.de>
	<CA+hUKG+yxxnFWvp4h_HgJvptQ2uKE4aKtDd7e5nmr61Soe6a2Q@mail.gmail.com>

Hi,

On 2022-01-17 17:25:19 +1300, Thomas Munro wrote:
> I reordered the arguments, tested locally under the buildfarm client script,
> and pushed.  I'll keep an eye on the build farm.

After the reloptions fix the tests seem much more likely to succeed than
before. Progress!

Unfortunately we don't quite seem there yet:

I saw a couple failures like:
https://api.cirrus-ci.com/v1/artifact/task/5394938773897216/regress_diffs/build/testrun/recovery/t/0...
(from https://cirrus-ci.com/task/5394938773897216?logs=check_world#L183 )

 -- Should succeed
 DROP TABLESPACE regress_tblspace_renamed;
+ERROR:  tablespace "regress_tblspace_renamed" is not empty


I assume the reason we see this semi-regularly when the regression tests run
as part of 027_stream_regress, but not in the main regression test run, is
similar to the reloptions problem, namely that we run with a much smaller
shared buffers.

I assume what happens is that this just makes the known problem of bgwriter or
some other process keeping open a filehandle to an already deleted relation,
preventing the deletion to "fully" take effect, worse.

Greetings,

Andres Freund





view thread (82+ messages)  latest in thread

Message-ID: <20220121194827.7eau4ulhrfol3npd@alap3.anarazel.de>
Permalink:  ../20220121194827.7eau4ulhrfol3npd@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220121194827.7eau4ulhrfol3npd@alap3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, thomas.munro@gmail.com, michael@paquier.xyz, andrew@dunslane.net, lubennikovaav@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: A test for replay of regression tests
  In-Reply-To: <20220121194827.7eau4ulhrfol3npd@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox