From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: pgbf@twiska.com, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date: Mon, 24 Jan 2022 00:02:43 -0800
Message-ID: <20220124080243.GA1187287@rfd.leadboat.com> (raw)
In-Reply-To: <20220124023432.mol34o34kmjrbcvo@alap3.anarazel.de>
References: <CA+hUKGLoV=wYa301GWaQUb7zb4cNE4QLqnik_QbHe-=3kpp=Ew@mail.gmail.com>
<20220116210241.GC756210@rfd.leadboat.com>
<20220122185241.GA1095169@rfd.leadboat.com>
<CA+hUKGLbtEfCMXA9H+W6R-FRS7yojs5TdfqbNdEetTa7pB4Khw@mail.gmail.com>
<20220123232927.GA1131882@rfd.leadboat.com>
<78685FA0-EEC6-4AFB-B323-C37A99C82563@anarazel.de>
<20220124011759.GC1131882@rfd.leadboat.com>
<20220124014054.cd4yranmj5wyf7g7@alap3.anarazel.de>
<20220124021007.GA1170596@rfd.leadboat.com>
<20220124023432.mol34o34kmjrbcvo@alap3.anarazel.de>
On Sun, Jan 23, 2022 at 06:34:32PM -0800, Andres Freund wrote:
> On 2022-01-23 18:10:07 -0800, Noah Misch wrote:
> > On Sun, Jan 23, 2022 at 05:40:54PM -0800, Andres Freund wrote:
> > > Test::more's description: "If it's something the programmer hasn't done yet,
> > > use TODO. This is for any code you haven't written yet, or bugs you have yet
> > > to fix, but want to put tests in your testing script (always a good idea)."
> >
> > Could do that. Every run that doesn't get the flaky failure will print a
> > message like "TODO passed: 3-5", though the test file could mitigate that by
> > declaring the TODO only on configurations where we expect a failure.
>
> Yea, that's what I was thinking we'd do.
>
> > The
> > 027_stream_regress.pl trouble involves reaching a die(), not failing a test in
> > this sense, so that one would take more work.
>
> I'm really not a perl person... But my understanding is that todo_skip() would
> address this? I.e. something like
>
> TODO:
> {
> $todo_skip "linux/sparc has unaddressed problems with partial page overwrites"
> if ($^O eq 'linux' and $Config{archname'} ~= 'sparc');
>
> ok(whatever is broken);
> }
Yes. todo_skip() behaves much like regular skip(). The enclosed tests don't
run. Hence, it prevents die() and BAIL_OUT() failures. $TODO is a different
beast; tests still run, and it changes the reporting. For 003_cic_2pc.pl, I'm
fine using $TODO so we continue to run all test commands and quietly log their
results. For 027_stream_regress.pl, which would need deep changes to use
$TODO, it works to use any of todo_skip, skip, or skip_all. I prefer
skip_all, because it prints the skip reason to gmake's stdout. (If the number
of affected users is zero as theorized, the choice doesn't matter.) Any
objections? Here's the appearance of each strategy on gmake's stdout:
=== todo_skip
[23:56:45] t/003_cic_2pc.pl .. ok 60 ms ( 0.00 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.05 CPU)
[23:56:45]
All tests successful.
Files=1, Tests=5, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.06 CPU)
Result: PASS
=== skip
[23:55:47] t/003_cic_2pc.pl .. ok 59 ms ( 0.00 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.05 CPU)
[23:55:48]
All tests successful.
Files=1, Tests=5, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.06 CPU)
Result: PASS
=== skip_all
[23:31:04] t/003_cic_2pc.pl .. skipped: filesystem bug
[23:31:04]
Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.05 cusr 0.00 csys = 0.07 CPU)
Result: NOTESTS
=== $TODO, test 1 is expected fail, tests 2-5 are unexpected pass
[23:32:32] t/003_cic_2pc.pl .. ok 1371 ms ( 0.01 usr 0.00 sys + 0.51 cusr 0.24 csys = 0.76 CPU)
[23:32:33]
All tests successful.
Test Summary Report
-------------------
t/003_cic_2pc.pl (Wstat: 0 Tests: 5 Failed: 0)
TODO passed: 2-5
Files=1, Tests=5, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.51 cusr 0.24 csys = 0.77 CPU)
Result: PASS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andres@anarazel.de, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
In-Reply-To: <20220124080243.GA1187287@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox