From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: David Steele <david@pgmasters.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Date: Thu, 3 Feb 2022 13:25:39 -0800
Message-ID: <20220203212539.GA1082940@nathanxps13> (raw)
In-Reply-To: <CA+TgmoYDiOPrEAwzf4MAp-RPRo4TgU1MHfuDOBz-FupWfDa74A@mail.gmail.com>
References: <20220130003148.GA459597@nathanxps13>
<20220130050141.GA582209@nathanxps13>
<20220201013608.GA737363@nathanxps13>
<CA+TgmobN3L+ddDK_CQitfR_dSSoeXVxkUu=d57xioh-mW8EXoQ@mail.gmail.com>
<20220202224433.GA1036711@nathanxps13>
<CA+TgmoYJ9pTRdX35E35q=+5zetrpOyBh=QnU532C4zvsL1xWdQ@mail.gmail.com>
<20220203192747.GA1080581@nathanxps13>
<CA+Tgmoa+Sp9w2CAkEJ4MuD2sAjePOmVWiYh1yDvVx4P--4ZbUg@mail.gmail.com>
<20220203211121.GA1081379@nathanxps13>
<CA+TgmoYDiOPrEAwzf4MAp-RPRo4TgU1MHfuDOBz-FupWfDa74A@mail.gmail.com>
On Thu, Feb 03, 2022 at 04:15:30PM -0500, Robert Haas wrote:
> On Thu, Feb 3, 2022 at 4:11 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> On Thu, Feb 03, 2022 at 04:04:33PM -0500, Robert Haas wrote:
>> > So apparently we need to either skip this test when wal_level=minimal,
>> > or force a higher wal_level to be used for this particular test. Not
>> > sure what the existing precedents are, if any.
>>
>> The only precedent I've found so far is test_decoding, which sets wal_level
>> to "logical." Perhaps we can just set it to "replica" in
>> basic_archive.conf.
>
> Yeah, that seems to make sense.
024_archive_recovery.pl seems to do something similar. Patch attached.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.comAttachments:
[text/x-diff] fix-basic-archive-test.patch (360B, ../20220203212539.GA1082940@nathanxps13/2-fix-basic-archive-test.patch)
download | inline diff:diff --git a/contrib/basic_archive/basic_archive.conf b/contrib/basic_archive/basic_archive.confindex b26b2d4144..db029f4b8e 100644--- a/contrib/basic_archive/basic_archive.conf+++ b/contrib/basic_archive/basic_archive.conf@@ -1,3 +1,4 @@
archive_mode = 'on'
archive_library = 'basic_archive'
basic_archive.archive_directory = '.'
+wal_level = 'replica'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, bossartn@amazon.com, david@pgmasters.net, masao.fujii@oss.nttdata.com, michael@paquier.xyz, magnus@hagander.net, sfrost@snowman.net
Subject: Re: archive modules
In-Reply-To: <20220203212539.GA1082940@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox