From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: bruce@momjian.us
Cc: tgl@sss.pgh.pa.us
Subject: Re: GUC flags
Date: Mon, 7 Feb 2022 21:07:28 -0600
Message-ID: <20220208030727.GH31460@telsasoft.com> (raw)
In-Reply-To: <YgHK56v7NYXGso+x@paquier.xyz>
References: <YfDqSVZlzdzZO9x6@paquier.xyz>
<20220128043621.GA23027@telsasoft.com>
<YfTg/WHNLVVygy8v@paquier.xyz>
<20220130001849.GR23027@telsasoft.com>
<Yfdw9WWJ/BMl7QYd@paquier.xyz>
<20220131225645.GZ23027@telsasoft.com>
<Yf9YGSwPiMu0c7fP@paquier.xyz>
<YgCGjDK/b13shS0o@paquier.xyz>
<20220207030414.GC31460@telsasoft.com>
<YgHK56v7NYXGso+x@paquier.xyz>
On Tue, Feb 08, 2022 at 10:44:07AM +0900, Michael Paquier wrote:
> What do you think about the updated version attached? I have applied
> the addition of config_data() separately.
Looks fine
> + # Check if this line matches a GUC parameter.
> + if ($line =~ m/^#?([_[:alpha:]]+) (= .*|[^ ]*$)/)
I think this is the regex I wrote to handle either "name = value" or "name
value", which was needed between f47ed79cc..4d7c3e344. See skip_equals.
It's fine the way it is, but could also remove the 2nd half of the alternation
(|), since GUCs shouldn't be added to sample.conf without '='.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org, bruce@momjian.us, tgl@sss.pgh.pa.us
Subject: Re: GUC flags
In-Reply-To: <20220208030727.GH31460@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox