pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Jeevan Ladhe <jeevanladhe.os@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c
Date: Sat, 12 Feb 2022 15:12:21 -0600
Message-ID: <20220212211220.GJ31460@telsasoft.com> (raw)
In-Reply-To: <20220211152944.GD31460@telsasoft.com>
References: <CA+TgmoYzYVwkDpwHru5+Lf5f0u4cTN6FeBLsJeHxXTBS7v=11A@mail.gmail.com>
	<YgPEhynPPLUFf7x3@toroid.org>
	<CAN1g5_FEDTQXk8h_bUQcc0ULKco=Tv=_QGuiwJ73Qay=T2monQ@mail.gmail.com>
	<CANm22Cj4qakrKy5Evkt29tnW9WqqgfB1u3O_btwYGhPp_M18pw@mail.gmail.com>
	<CAN1g5_FeDmiA9D8wdG2W6Lkq5CpubxOAqTmd2et9hsinTJtsMQ@mail.gmail.com>
	<CANm22Cg9cArXEaYgHVZhCnzPLfqXCZLAzjwTq7Fc0quXRPfbxA@mail.gmail.com>
	<CAN1g5_FrApD0OFbWMF8PRF9W+EAPEV6wS7cCJp-h0qMe7cg8aA@mail.gmail.com>
	<CA+TgmoYUDEJga2qV_XbAZ=pGEBaOsgFmzZ6Ac4_sRwOm_+UeHA@mail.gmail.com>
	<CANm22CgPb1qZRHxqr6jzP2Xt_c3=6TiCBv_AB5G9eqBP90XDgw@mail.gmail.com>
	<20220211152944.GD31460@telsasoft.com>

The LZ4 patches caused new compiler warnings.
It's the same issue that was fixed at 71cbbbbe8 for gzip.
I think they would've been visible in the CI environment, too.

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse&dt=2022-02-12%2005%3A08%3A4...
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/basebackup_lz4.c", line 87: warning: Function has no return statement : bbsink_lz4_new

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=bowerbird&dt=2022-02-12%2013%3A11%...
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hamerkop&dt=2022-02-12%2010%3A04%3...
warning C4715: 'bbsink_lz4_new': not all control paths return a value

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=anole&dt=2022-02-12%2005%3A46%3A44...
"basebackup_lz4.c", line 87: warning #2940-D: missing return statement at end of non-void function "bbsink_lz4_new"

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse&dt=2022-02-12%2005%3A08%3A4...
"/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/basebackup_lz4.c", line 87: warning: Function has no return statement : bbsink_lz4_new





view thread (171+ messages)  latest in thread

Message-ID: <20220212211220.GJ31460@telsasoft.com>
Permalink:  ../20220212211220.GJ31460@telsasoft.com/
Also on:    postgresql.org/message-id/20220212211220.GJ31460@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, jeevanladhe.os@gmail.com, robertmhaas@gmail.com, dipesh.pandit@gmail.com, ams@toroid.org, 9erthalion6@gmail.com, jeevan.ladhe@enterprisedb.com, mark.dilger@enterprisedb.com, tushar.ahuja@enterprisedb.com
  Subject: Re: refactoring basebackup.c
  In-Reply-To: <20220212211220.GJ31460@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox