From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: 李杰(慎追) <adger.lj@alibaba-inc.com>
Cc: pgsql-hackers@lists.postgresql.org, 曾文旌(义从) <wenjing.zwj@alibaba-inc.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Subject: Re: CLUSTER on partitioned index
Date: Sat, 2 Apr 2022 19:21:11 +0200
Message-ID: <202204021721.myr2alroeunz@alvherre.pgsql> (raw)
In-Reply-To: <202204021711.zf24w66t6o6w@alvherre.pgsql>
Small things here.
1. in VACUUM FULL we only process partitions that are owned by the
invoking user. We don't have this test in the new code. I'm not sure
why do we do that there; is it worth doing the same here?
2. We should silently skip a partition that's a foreign table, I
suppose.
3. We do mark the index on the partitions as indisclustered AFAICS (we
claim that the partitioned table's index is not marked, which is
accurate). So users doing unadorned CLUSTER afterwards will get the
partitions clustered too, once they cluster the partitioned table. If
they don't want this, they would have to ALTER TABLE to remove the
marking. How likely is that this will be a problem? Maybe documenting
this point is enough.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Voy a acabar con todos los humanos / con los humanos yo acabaré
voy a acabar con todos (bis) / con todos los humanos acabaré ¡acabaré! (Bender)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pryzby@telsasoft.com, michael@paquier.xyz, adger.lj@alibaba-inc.com, wenjing.zwj@alibaba-inc.com, zyu@yugabyte.com
Subject: Re: CLUSTER on partitioned index
In-Reply-To: <202204021721.myr2alroeunz@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox