pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: David Steele <david@pgmasters.net>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: Tue, 5 Apr 2022 13:06:17 -0700
Message-ID: <20220405200617.GA1141296@nathanxps13> (raw)
In-Reply-To: <20220405152536.GT10577@tamriel.snowman.net>
References: <20220310000622.GA225595@nathanxps13>
	<622A941A.90909@anastigmatix.net>
	<20220311003834.GA597706@nathanxps13>
	<20220328203027.GK10577@tamriel.snowman.net>
	<20220329020948.GA311150@nathanxps13>
	<17837e22-9b8d-f8d7-bc8b-7d3eaee3186b@pgmasters.net>
	<20220404142247.GA663209@nathanxps13>
	<20220404154218.GA792581@nathanxps13>
	<4c4ae416-be44-754e-7ee0-7083c11e7cfb@pgmasters.net>
	<20220405152536.GT10577@tamriel.snowman.net>

On Tue, Apr 05, 2022 at 11:25:36AM -0400, Stephen Frost wrote:
> Please find attached an updated patch + commit message.  Mostly, I just
> went through and did a bit more in terms of updating the documentation
> and improving the comments (there were some places that were still
> worrying about the chance of a 'stray' backup_label file existing, which
> isn't possible any longer), along with some additional testing and
> review.  This is looking pretty good to me, but other thoughts are
> certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.

LGTM!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (86+ messages)  latest in thread

Message-ID: <20220405200617.GA1141296@nathanxps13>
Permalink:  ../20220405200617.GA1141296@nathanxps13/
Also on:    postgresql.org/message-id/20220405200617.GA1141296@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, sfrost@snowman.net, david@pgmasters.net, chap@anastigmatix.net, magnus@hagander.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
  In-Reply-To: <20220405200617.GA1141296@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox