From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Date: Tue, 3 May 2022 09:46:10 +0200
Message-ID: <202205030746.pfpbpywy7xp7@alvherre.pgsql> (raw)
In-Reply-To: <20220503014803.uknu3cwahwhbgrak@alap3.anarazel.de>
On 2022-May-02, Andres Freund wrote:
> > > pgindent uses some crazy formatting nearby:
> > > SendRecoveryConflictWithBufferPin(
> > > PROCSIG_RECOVERY_CONFLICT_STARTUP_DEADLOCK);
> >
> > I do not believe that that line break is pgindent's fault.
>
> Oh - I'm fairly certain I've seen pgindent do that in the past. But you're
> right, it's not. Perhaps it was an older version of pgindent?
No, it's never done that. We used to fold lines that way manually,
because pgindent used to push the argument to the left, but that changed
at commit 382ceffdf7f6.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria. Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, thomas.munro@gmail.com
Subject: Re: failures in t/031_recovery_conflict.pl on CI
In-Reply-To: <202205030746.pfpbpywy7xp7@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox