pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Przemysław Sztoch <przemyslaw@sztoch.pl>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add --{no-,}bypassrls flags to createuser
Date: Mon, 23 May 2022 09:37:35 -0700
Message-ID: <20220523163735.GA938919@nathanxps13> (raw)
In-Reply-To: <e2659356769a778308bd3e18732ceeb2@oss.nttdata.com>
References: <YmDdxXPVNR8Km0v/@paquier.xyz>
	<CA+TgmoYeZg5deFv+r-dDvWQLuSOiTNAUbcsx4kY2XhGSeGz7FA@mail.gmail.com>
	<CAKFQuwa7kaFmEMszAAkpy-RiYZjW4M3MGo4-EidExZbOAgwQkg@mail.gmail.com>
	<20220425201947.GA2935432@nathanxps13>
	<d2d771c6cf1ed0f59513eb01c0cc0c78@oss.nttdata.com>
	<a720383d-9bf2-fcb7-22fa-aeea114c86a5@sztoch.pl>
	<4975ec63b73cfe4034867e90edbe16f8@oss.nttdata.com>
	<20220520214519.GA832375@nathanxps13>
	<Yos37n9xGnax7uBg@paquier.xyz>
	<e2659356769a778308bd3e18732ceeb2@oss.nttdata.com>

On Mon, May 23, 2022 at 11:55:43PM +0900, Shinya Kato wrote:
> On 2022-05-23 16:29, Michael Paquier wrote:
>> May I ask for the addition of tests when one specifies multiple
>> switches for --admin and --member?  This would check the code path
>> where you build a list of role names.  You could check fancier string
>> patterns, while on it, to look after the use of fmtId(), say with
>> role names that include whitespaces or such.
> 
> Thanks!
> I changed to the test that describes multiple "-m".
> It seems to be working without any problems, how about it?

Michael also requested a test for multiple -a switches and for fancier
string patterns.  Once that is taken care of, I think this can be marked as
ready-for-committer.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (41+ messages)  latest in thread

Message-ID: <20220523163735.GA938919@nathanxps13>
Permalink:  ../20220523163735.GA938919@nathanxps13/
Also on:    postgresql.org/message-id/20220523163735.GA938919@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, Shinya11.Kato@oss.nttdata.com, michael@paquier.xyz, przemyslaw@sztoch.pl, david.g.johnston@gmail.com, robertmhaas@gmail.com, horikyota.ntt@gmail.com, daniel@yesql.se
  Subject: Re: Add --{no-,}bypassrls flags to createuser
  In-Reply-To: <20220523163735.GA938919@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox