From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
Date: Thu, 26 May 2022 15:52:18 -0500
Message-ID: <20220526205218.GC19626@telsasoft.com> (raw)
In-Reply-To: <Yo/mWGJjCHOH3eB1@paquier.xyz>
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
<Yo3Z5JzHXn7sIe9N@paquier.xyz>
<b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
<Yo/mWGJjCHOH3eB1@paquier.xyz>
On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote:
> On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote:
> > I chose TESTOUTDIR because it corresponds to the tmp_check directory, so
> > that the output files of the pg_upgrade run are removed when the test
> > artifacts are cleaned up. When using TESTDIR, the pg_upgrade output files
> > end up in the build directory, which is less bad than the source directory,
> > but still not ideal.
>
> Where does the choice of TESTOUTDIR come from? I am a bit surprised
> by this choice, to be honest, because there is no trace of it in the
> buildfarm client or the core code. TESTDIR, on the other hand, points
> to tmp_check/ if not set. It gets set it in vcregress.pl and
> Makefile.global.in.
It looks like Peter working on top of the meson branch.
TESTOUTDIR is not yet in master.
https://commitfest.postgresql.org/38/3395/https://github.com/anarazel/postgres/tree/mesonhttps://github.com/anarazel/postgres/commit/e754bde6d0d3cb6329a5bf568e19eb271c3bdc7c
commit e754bde6d0d3cb6329a5bf568e19eb271c3bdc7c
Author: Andres Freund <andres@anarazel.de>
Date: Mon Feb 14 21:47:07 2022 -0800
wip: split TESTDIR into two.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, peter.eisentraut@enterprisedb.com
Subject: Re: pg_upgrade test writes to source directory
In-Reply-To: <20220526205218.GC19626@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox