From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade test writes to source directory
Date: Thu, 26 May 2022 16:36:47 +0200
Message-ID: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com> (raw)
In-Reply-To: <Yo3Z5JzHXn7sIe9N@paquier.xyz>
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
<Yo3Z5JzHXn7sIe9N@paquier.xyz>
On 25.05.22 09:25, Michael Paquier wrote:
>> It looks like an addition of
>>
>> chdir $ENV{TESTOUTDIR};
>>
>> could fix it. Please check the patch.
> I think that you mean TESTDIR, and not TESTOUTDIR?
I chose TESTOUTDIR because it corresponds to the tmp_check directory, so
that the output files of the pg_upgrade run are removed when the test
artifacts are cleaned up. When using TESTDIR, the pg_upgrade output
files end up in the build directory, which is less bad than the source
directory, but still not ideal.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz
Subject: Re: pg_upgrade test writes to source directory
In-Reply-To: <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox