From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: ccache, MSVC, and meson
Date: Tue, 14 Jun 2022 16:08:19 -0500
Message-ID: <20220614210819.GW29853@telsasoft.com> (raw)
In-Reply-To: <20220525044817.kczou2nkbtk46itj@alap3.anarazel.de>
References: <20220522232606.GZ19626@telsasoft.com>
<20220524193059.n432rlzezckxr6x2@alap3.anarazel.de>
<20220524195202.GK19626@telsasoft.com>
<20220524203039.xyqjggtytsyizsbl@alap3.anarazel.de>
<20220524221747.GM19626@telsasoft.com>
<20220525044817.kczou2nkbtk46itj@alap3.anarazel.de>
On Tue, May 24, 2022 at 09:48:17PM -0700, Andres Freund wrote:
> Hi,
>
> On 2022-05-24 17:17:47 -0500, Justin Pryzby wrote:
> > Also, /O2 cuts ~3 minutes off the test time on cirrus, which seems worth it,
> > except that it omits frame pointers, which probably breaks debuggability.
>
> It likely also causes us to use the non-debug C runtime? Which IMO would be
> bad, it does detect quite a few problems that are otherwise hard to find.
>
>
> > And when I pass /Oy- to "avoid omitting" frame pointers, several tests crash...
>
> Huh. Do you get a backtrace containing anything remotely meaningful?
I looked at this again. The issue isn't caused by optimizations, but
(apparently) by an absence of options in "msbuild --buildtype plain".
Adding /MD or /MDd fixes the issue.
That's done in the existing build system here:
src/tools/msvc/MSBuildProject.pm: runtime => 'MultiThreadedDebugDLL'
src/tools/msvc/MSBuildProject.pm: runtime => 'MultiThreadedDLL'
https://cirrus-ci.com/task/4895613501308928
BTW: vcvarsall isn't needed in the "check_world" scripts.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, melanieplageman@gmail.com, peter.eisentraut@enterprisedb.com, daniel@yesql.se
Subject: Re: ccache, MSVC, and meson
In-Reply-To: <20220614210819.GW29853@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox