pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Roberto Mello <roberto.mello@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: doc: BRIN indexes and autosummarize
Date: Tue, 5 Jul 2022 14:58:38 -0500
Message-ID: <20220705195838.GT13040@telsasoft.com> (raw)
In-Reply-To: <20220705114727.ryirrnks7rijhdh3@alvherre.pgsql>
References: <20220704212227.GN13040@telsasoft.com>
	<YsNScLPHKcBBp4oO@ahch-to>
	<20220705114727.ryirrnks7rijhdh3@alvherre.pgsql>

On Tue, Jul 05, 2022 at 01:47:27PM +0200, Alvaro Herrera wrote:
> OK, I have adopted all your proposed changes, thanks for submitting in
> both forms.  I did some more wordsmithing and pushed, to branches 12 and
> up.  11 fails 'make check', I think for lack of Docbook id tags, and I
> didn't want to waste more time.  Kindly re-read the result and let me
> know if I left something unaddressed, or made something worse.  The
> updated text is already visible in the website:
> https://www.postgresql.org/docs/devel/brin-intro.html

One issue:

+   summarized range, the range that the new page belongs into
+   does not automatically acquire a summary tuple;

"belongs into" sounds wrong - "belongs to" is better.

I'll put that change into my "typos" branch to fix later if it's not addressed
in this thread.

-- 
Justin





view thread (12+ messages)  latest in thread

Message-ID: <20220705195838.GT13040@telsasoft.com>
Permalink:  ../20220705195838.GT13040@telsasoft.com/
Also on:    postgresql.org/message-id/20220705195838.GT13040@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, alvherre@alvh.no-ip.org, jcasanov@systemguards.com.ec, roberto.mello@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: doc: BRIN indexes and autosummarize
  In-Reply-To: <20220705195838.GT13040@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox