pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bernd Helmle <mailings@oopsware.de>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: pgsql-hackers@postgresql.org, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Subject: Re: Allowing REINDEX to have an optional name
Date: Wed, 20 Jul 2022 07:27:07 -0500
Message-ID: <20220720122707.GI12702@telsasoft.com> (raw)
In-Reply-To: <YtYvbtPCW2ztdUHy@paquier.xyz>
References: <CANbhV-EmOh-XTssH5TwannC2S1VDN5zK-b+oZKs8UdyUtc2oUw@mail.gmail.com>
	<YrvWoAsaX/gUG2re@paquier.xyz>
	<CANbhV-EL4+RK49Qmk66zFmTiEEhT6TKia0ow_t5zogV1-FfAEw@mail.gmail.com>
	<1386216.1656884491@sss.pgh.pa.us>
	<YsKP6wJ0+XvF+6/8@paquier.xyz>
	<CANbhV-H2Y=jM1QVRkT-OOa2+KPTd3po+=2LmZ35DmTidjRovGg@mail.gmail.com>
	<CANbhV-GzM_KukbDm6qWFRfpkv==uDjXOOU-KMHqRz71ojce_rg@mail.gmail.com>
	<YtOqA7ldcJQADEE8@paquier.xyz>
	<20220719022652.GE12702@telsasoft.com>
	<YtYvbtPCW2ztdUHy@paquier.xyz>

On Tue, Jul 19, 2022 at 01:13:34PM +0900, Michael Paquier wrote:
> > It looks like you named the table "toast_relfilenodes", but then also store
> > to it data for non-toast tables.
> 
> How about naming that index_relfilenodes?  One difference with what I
> posted previously and 5fb5b6 is the addition of an extra regclass that
> stores the parent table, for reference in the output.

Looks fine

> -	'CREATE TABLE toast_relfilenodes (parent regclass, indname regclass, relfilenode oid);'
> +	'CREATE TABLE index_relfilenodes (parent regclass, indname regclass, relfilenode oid);'

-- 
Justi





view thread (41+ messages)  latest in thread

Message-ID: <20220720122707.GI12702@telsasoft.com>
Permalink:  ../20220720122707.GI12702@telsasoft.com/
Also on:    postgresql.org/message-id/20220720122707.GI12702@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, michael@paquier.xyz, simon.riggs@enterprisedb.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, mailings@oopsware.de, ashutosh.bapat.oss@gmail.com, ashutosh.bapat@enterprisedb.com
  Subject: Re: Allowing REINDEX to have an optional name
  In-Reply-To: <20220720122707.GI12702@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox