From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: out of date comment in commit_ts.c
Date: Tue, 26 Jul 2022 10:33:43 -0700
Message-ID: <20220726173343.GA154110@nathanxps13> (raw)
Hi hackers,
I noticed that commit_ts.c has the following comment:
* XLOG interactions: this module generates an XLOG record whenever a new
* CommitTs page is initialized to zeroes. Also, one XLOG record is
* generated for setting of values when the caller requests it; this allows
* us to support values coming from places other than transaction commit.
* Other writes of CommitTS come from recording of transaction commit in
* xact.c, which generates its own XLOG records for these events and will
* re-perform the status update on redo; so we need make no additional XLOG
* entry here.
IIUC the ability for callers to request WAL record generation is no longer
possible as of 08aa89b [0]. Should the second sentence be removed?
[0] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=08aa89b
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com
Subject: Re: out of date comment in commit_ts.c
In-Reply-To: <20220726173343.GA154110@nathanxps13>
References: <20220726173343.GA154110@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox