pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: pg_upgrade errno
Date: Sun, 31 Jul 2022 08:41:35 -0500
Message-ID: <20220731134135.GY15006@telsasoft.com> (raw)

Since 3a769d823 (pg_upgrade: Allow use of file cloning)
file.c has had:

-       if (ioctl(dest_fd, FICLONE, src_fd) < 0)
-       {
-               unlink(dst);
-               pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s",
-                                schemaName, relName, src, dst, strerror(errno));
-       }

But errno should be saved before strerror/%m.

-- 
Justin

view thread (4+ messages)  latest in thread

Message-ID: <20220731134135.GY15006@telsasoft.com>
Permalink:  ../20220731134135.GY15006@telsasoft.com/
Also on:    postgresql.org/message-id/20220731134135.GY15006@telsasoft.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, peter.eisentraut@enterprisedb.com
  Subject: Re: pg_upgrade errno
  In-Reply-To: <20220731134135.GY15006@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox