From: Noah Misch <noah@leadboat.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: robertmhaas@gmail.com
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: remove more archiving overhead
Date: Wed, 3 Aug 2022 00:16:17 -0700
Message-ID: <20220803071617.GA3817792@rfd.leadboat.com> (raw)
In-Reply-To: <20220802050219.GA475090@nathanxps13>
References: <20220707182251.GA2255242@nathanxps13>
<ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>
<20220707220716.GA2258527@nathanxps13>
<20220708.105652.1551158050191356887.horikyota.ntt@gmail.com>
<44dbf5e4-8eec-da56-daba-755128b3723e@pgmasters.net>
<20220708165450.GA2356733@nathanxps13>
<20220731065156.GA3694276@rfd.leadboat.com>
<20220802050219.GA475090@nathanxps13>
On Mon, Aug 01, 2022 at 10:02:19PM -0700, Nathan Bossart wrote:
> On Sat, Jul 30, 2022 at 11:51:56PM -0700, Noah Misch wrote:
> > Inviting the administrator to resolve things is more dangerous than just
> > returning true. I recommend making this text more opinionated and simpler:
> > libraries must return true. Alternately, if some library has found a good
> > reason to return false, this paragraph could give the reason. I don't know of
> > such a reason, though.
>
> Your suggestion seems reasonable to me. I've attached a small patch.
> --- a/doc/src/sgml/backup.sgml
> +++ b/doc/src/sgml/backup.sgml
> @@ -691,11 +691,9 @@ test ! -f /mnt/server/archivedir/00000001000000A900000065 && cp pg_wal/0
> system crashes before the server makes a durable record of archival success,
> the server will attempt to archive the file again after restarting (provided
> archiving is still enabled). When an archive library encounters a
> - pre-existing file, it may return <literal>true</literal> if the WAL file has
> + pre-existing file, it should return <literal>true</literal> if the WAL file has
> identical contents to the pre-existing archive and the pre-existing archive
> - is fully persisted to storage. Alternatively, the archive library may
> - return <literal>false</literal> anytime a pre-existing file is encountered,
> - but this will require manual action by an administrator to resolve. If a
> + is fully persisted to storage. If a
> pre-existing file contains different contents than the WAL file being
> archived, the archive library <emphasis>must</emphasis> return
> <literal>false</literal>.
Works for me. Thanks.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, nathandbossart@gmail.com, david@pgmasters.net, horikyota.ntt@gmail.com, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com
Subject: Re: remove more archiving overhead
In-Reply-To: <20220803071617.GA3817792@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox